You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/10 07:15:21 UTC
[PR] feat: add instance-scoped Apache ACL 2.0 read foundation [rocketmq-dashboard]
Aias00 opened a new pull request, #1454:
URL: https://github.com/apache/rocketmq-dashboard/pull/1454
## Summary
Consolidates the implementation portions of #1312 into one reviewable Apache ACL 2.0 read foundation:
- expose selected-instance ACL capabilities without claiming remote enforcement
- resolve optional external Apache admin credential references into authenticated runtime AdminClients
- cache clients by NameServer endpoint and non-secret credential reference
- expose `GET /api/acl/remote/rules?instanceId=...`, querying ACL 2.0 policies from every discovered master Broker
- preserve provider provenance and partial-failure details; remote failures never fall back to Studio-local ACL records
## Explicit non-goals
- no remote ACL mutations
- no ACL 1.0 policy CRUD claim (it needs a separate file/config provider)
- no cloud ACL provider
## Validation
- `JAVA_HOME=$( /usr/libexec/java_home -v 21 ) mvn -Dtest=AclServiceTest,AclControllerTest,ApacheAclReadServiceTest,RuntimeAdminClientResolverTest,MqAdminExtFactoryTest,InstanceServiceTest test` (116 tests)
Closes #1430
Closes #1449
Part of #1312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add instance-scoped Apache ACL 2.0 read foundation [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #1454:
URL: https://github.com/apache/rocketmq-dashboard/pull/1454#issuecomment-5249225483
Follow-up after rebasing onto the current `rocketmq-studio` baseline:
- The requested `adminCredentialRef` entity/VO mappings and mapper-backed round-trip coverage remain present.
- Apache remote-read capability reporting, non-Apache UI alignment, and dedicated `RemoteAclPolicyVO` response records remain present.
- The branch now rebases cleanly at `13856a41`.
Validation was re-run with the independent baseline compilation fix from #1530 temporarily applied, without adding it to this PR:
```
JAVA_HOME=$(/usr/libexec/java_home -v 21) PATH="$JAVA_HOME/bin:$PATH" \
mvn -f server/pom.xml -Dtest=AclControllerTest,AclServiceTest,ApacheAclReadServiceTest,InstanceServiceTest,MybatisPlusInstanceRepositoryTest,MqAdminExtFactoryTest,RuntimeAdminClientResolverTest test
```
Result: 56 tests passed. Please re-review the resolved blocking item.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add instance-scoped Apache ACL 2.0 read foundation [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #1454:
URL: https://github.com/apache/rocketmq-dashboard/pull/1454#issuecomment-5247069198
Addressed the review in a41bfe16:
- Persisted adminCredentialRef in both MyBatis repository mappings and added an H2-backed mapper/repository round-trip test.
- Reported remote ACL 2.0 read capability for Apache instances while keeping remote writes disabled.
- Aligned the instance edit UI so the admin credential reference is shown only for APACHE, matching RuntimeAdminClientResolver.
- Replaced the remoting AclInfo REST response type with dedicated RemoteAclPolicyVO response records.
Validated with the focused backend suite (61 tests) and frontend production build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add instance-scoped Apache ACL 2.0 read foundation [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #1454:
URL: https://github.com/apache/rocketmq-dashboard/pull/1454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org