[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #2731: [ARTEMIS-2401]: Implement the Pause method for a Topic

[GitBox <gi...@apache.org>]

franz1981 commented on a change in pull request #2731: [ARTEMIS-2401]: Implement the Pause method for a Topic
URL: https://github.com/apache/activemq-artemis/pull/2731#discussion_r298474014
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/AddressInfo.java
 ##########
 @@ -136,6 +138,18 @@ public void setBindingRemovedTimestamp(long bindingRemovedTimestamp) {
       this.bindingRemovedTimestamp = bindingRemovedTimestamp;
    }
 
+   public void pause() {
 
 Review comment:
   How do you handle the case where there are racing pause/resume calls? 
   It is something that could happen or the paused field is supposed to be single-writer?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services