回复：[DISCUSS] How to handle Ip-clearance for apache rocketmq community projects

["王启伟(孝孺)" <qi...@alibaba-inc.com>]

Hi Justin&dev,    Thanks for your time, Let me give some explanation for your questions.    rocketmq-cpp client for both windows and linux are located at: https://github.com/apache/rocketmq-externals/tree/master/rocketmq-cpp
    - Does the zip includes any 3rd party code or code based on 3rd party code? If so how was it licensed?
    I searched all directories, and did not find any .zip file.       - What are the dependancies of the code?    rocketmq-cpp supports cross-platform for windows and linux, so it depends on 3 libs: boost-1.56, libevent-2.0.22, jsoncpp-0.10.6.
    - Have all contributors to the code signed a ICLA? Can we list them out?
    I had signed ICLA before, only me contributes this rocketmq-cpp client currently, looking forward to new volunteers.
------------------------------------------------------------------发件人：Justin Mclean <ju...@classsoftware.com>发送时间：2018年1月5日(星期五) 09:28收件人：dev <de...@rocketmq.apache.org>主　题：Re: [DISCUSS] How to handle Ip-clearance for apache rocketmq community projects
Hi,

BTW I took a look at that zip and it seems to contain a compiled version of the code. Does it contain all the source code need to generate that? The software grant should only include source code not any .exes or .dlls.

Thanks,
Justin

回复：[DISCUSS] How to handle Ip-clearance for apache rocketmq community projects

["王启伟(孝孺)" <qi...@alibaba-inc.com>]

Hi,
Thanks for that, looking there, a see a couple of minor issues:
- A number of .ccp and .h are files are missing headers. It seems a little random which files have ASF headers and which don’t.
- There is some 3rd party code in the repo for instance big_endian.cpp/.h and code in src/thread/disruptor. There have permissive licenses so there’s no issues there.
>     I will check each files, and add ASF headers to all of them, thanks.

Given the above are you 100% sure all files have been developed in the project and that none of the 20 or 30 files with missing header have came from elsewhere?
>    big_endian files are copied from Chromium and Disruptor files in src/thread/disruptor are copied from github, these codes have permissive licenses.
Has anyone contributed in the past to the code base other than yourself?
>     All functions are coded and tested by myself.

------------------------------------------------------------------发件人：Justin Mclean <ju...@classsoftware.com>发送时间：2018年1月5日(星期五) 12:15收件人：dev <de...@rocketmq.apache.org>; 王启伟(孝孺) <qi...@alibaba-inc.com>主　题：Re: [DISCUSS] How to handle Ip-clearance for apache rocketmq community projects
Hi,

> Thanks for your time, Let me give some explanation for your questions. Rocketmq-cpp client for both windows and linux are located at: https://github.com/apache/rocketmq-externals/tree/master/rocketmq-cpp

Thanks for that, looking there, a see a couple of minor issues:
- A number of .ccp and .h are files are missing headers. It seems a little random which files have ASF headers and which don’t.
- There is some 3rd party code in the repo for instance big_endian.cpp/.h and code in src/thread/disruptor. There have permissive licenses so there’s no issues there.

Given the above are you 100% sure all files have been developed in the project and that none of the 20 or 30 files with missing header have came from elsewhere?

>     I had signed ICLA before, only me contributes this rocketmq-cpp client currently, looking forward to new volunteers.

Has anyone contributed in the past to the code base other than yourself?

Thanks,
Justin

Re: [DISCUSS] How to handle Ip-clearance for apache rocketmq community projects

[Justin Mclean <ju...@classsoftware.com>]

Hi,

> Thanks for your time, Let me give some explanation for your questions. Rocketmq-cpp client for both windows and linux are located at: https://github.com/apache/rocketmq-externals/tree/master/rocketmq-cpp

Thanks for that, looking there, a see a couple of minor issues:
- A number of .ccp and .h are files are missing headers. It seems a little random which files have ASF headers and which don’t.
- There is some 3rd party code in the repo for instance big_endian.cpp/.h and code in src/thread/disruptor. There have permissive licenses so there’s no issues there.

Given the above are you 100% sure all files have been developed in the project and that none of the 20 or 30 files with missing header have came from elsewhere?

>     I had signed ICLA before, only me contributes this rocketmq-cpp client currently, looking forward to new volunteers.

Has anyone contributed in the past to the code base other than yourself?

Thanks,
Justin