You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2023/03/15 03:46:11 UTC
[GitHub] [incubator-uniffle] kaijchen opened a new pull request, #721: [MINOR] test: fix tempdir leak in KerberizedHdfs
kaijchen opened a new pull request, #721:
URL: https://github.com/apache/incubator-uniffle/pull/721
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Use JUnit 5 managed `@TempDir` in `KerberizedHdfs` test.
### Why are the changes needed?
The tempdir created by `KerberizedHdfs` is leaking.
It may cause test failures in some condition.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Before:
```console
$ mvn test -Dtest=HadoopFilesystemProviderTest
...
$ find . -name 'serverKS.jks'
./common/target/tmp/kerberizedDfsBaseDir1821275617120252168/serverKS.jks
```
After:
```console
$ mvn test -Dtest=HadoopFilesystemProviderTest
...
$ find . -name 'serverKS.jks'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #721: [MINOR] test: fix tempdir leak in KerberizedHdfs tests
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #721:
URL: https://github.com/apache/incubator-uniffle/pull/721#issuecomment-1471867882
We run
```
mvn package
````
The test fail
ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.896 s <<< FAILURE! - in org.apache.uniffle.common.filesystem.HadoopFilesystemProviderTest
[ERROR] org.apache.uniffle.common.filesystem.HadoopFilesystemProviderTest Time elapsed: 1.896 s <<< ERROR!
java.lang.Exception: java.io.FileNotFoundException: /Users/roryqi/Downloads/apache-uniffle-0.7.0-incubating-src/common/target/tmp/junit1553702532156578735/serverKS.jks (No such file or directory)
I revert this pr. The tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #721: [MINOR] test: fix tempdir leak in KerberizedHdfs tests
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #721:
URL: https://github.com/apache/incubator-uniffle/pull/721#issuecomment-1469401647
Merge to master & branch 0.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #721: [MINOR] test: fix tempdir leak in KerberizedHdfs tests
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #721:
URL: https://github.com/apache/incubator-uniffle/pull/721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #721: [MINOR] test: fix tempdir leak in KerberizedHdfs tests
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #721:
URL: https://github.com/apache/incubator-uniffle/pull/721#issuecomment-1469288705
@zuston please cherry-pick this to branch-0.7 after it's merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #721: [MINOR] test: fix tempdir leak in KerberizedHdfs tests
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #721:
URL: https://github.com/apache/incubator-uniffle/pull/721#issuecomment-1471961433
@jerqi OK, please revert this. I'll look into it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #721: [MINOR] test: fix tempdir leak in KerberizedHdfs tests
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #721:
URL: https://github.com/apache/incubator-uniffle/pull/721#issuecomment-1469283819
## [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/721?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#721](https://codecov.io/gh/apache/incubator-uniffle/pull/721?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8d3010b) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/1e605c7e07b3283b795407609daa4cd4f23bb641?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e605c7) will **increase** coverage by `2.31%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #721 +/- ##
============================================
+ Coverage 60.49% 62.81% +2.31%
- Complexity 1846 1850 +4
============================================
Files 228 215 -13
Lines 12744 10785 -1959
Branches 1067 1064 -3
============================================
- Hits 7710 6775 -935
+ Misses 4625 3660 -965
+ Partials 409 350 -59
```
[see 30 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-uniffle/pull/721/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #721: [MINOR] test: fix tempdir leak in KerberizedHdfs tests
Posted by "kaijchen (via GitHub)" <gi...@apache.org>.
kaijchen commented on PR #721:
URL: https://github.com/apache/incubator-uniffle/pull/721#issuecomment-1469408282
Thanks @jerqi for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org