You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/02 17:25:22 UTC

[GitHub] [superset] geido commented on a change in pull request #17570: fix: Save properties after applying changes in Dashboard

geido commented on a change in pull request #17570:
URL: https://github.com/apache/superset/pull/17570#discussion_r761314740



##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/edit_properties.test.ts
##########
@@ -97,10 +97,6 @@ describe('Dashboard edit action', () => {
       .get('[data-test="dashboard-title-input"]')
       .type(`{selectall}{backspace}${dashboardTitle}`);
 
-    cy.wait('@dashboardGet').then(() => {

Review comment:
       This was here because the color scheme was considered to e mandatory. This is not the case any longer




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org