You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/10/02 21:50:40 UTC

[GitHub] [incubator-yunikorn-core] yangwwei commented on pull request #213: [YUNIKORN-434] Fix for scheduler crash when the queueName in pod spec doesn't contain DOT

yangwwei commented on pull request #213:
URL: https://github.com/apache/incubator-yunikorn-core/pull/213#issuecomment-702972926


   Hi @bmv126 
   
   Thanks for raising this up. Good catch.
   Is the NPE happening at https://github.com/apache/incubator-yunikorn-core/blob/29d6c82323020773d75c37e2f81000115f01d43d/pkg/scheduler/scheduling_partition.go#L237?
   Can we do the check in `createSchedulingQueue()`?  We need to create some UT to cover this function as well, currently, it seems to be missing. Please take a look if we can add some UT `scheduling_partition_test.go`
   
   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org