You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/10/24 08:54:41 UTC

[GitHub] [logging-log4net] FreeAndNil opened a new pull request, #95: Defer creation of locking model to ActivateOptions()

FreeAndNil opened a new pull request, #95:
URL: https://github.com/apache/logging-log4net/pull/95

   The creation of the locking model instance is now deferred to ActivateOptions() so that defaultLockingModelType has an effect.
   + Tabify all appender code files (were inconsistent)
   + include pdb file in nuget package fpr better debugging experience
   
   @fluffynuts Could you please review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4net] FreeAndNil commented on pull request #95: Defer creation of locking model to ActivateOptions()

Posted by GitBox <gi...@apache.org>.
FreeAndNil commented on PR #95:
URL: https://github.com/apache/logging-log4net/pull/95#issuecomment-1289001648

   Hi @fluffynuts,
   
   i've reverted all the spacing changes.
   
   Regards


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4net] fluffynuts merged pull request #95: Defer creation of locking model to ActivateOptions()

Posted by GitBox <gi...@apache.org>.
fluffynuts merged PR #95:
URL: https://github.com/apache/logging-log4net/pull/95


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4net] fluffynuts commented on pull request #95: Defer creation of locking model to ActivateOptions()

Posted by GitBox <gi...@apache.org>.
fluffynuts commented on PR #95:
URL: https://github.com/apache/logging-log4net/pull/95#issuecomment-1288858922

   @FreeAndNil most of the changes here are whitespace, except:
   1. not setting `m_lockingModel` at line 1660
   2. working around pdb files not being in the nuget package
   
   I'm not 100% sure we want to expand the package size with the pdbs, considering the audience size of log4net. I'm open to be convinced here though (personally, since I use Rider, I can decompile any external sources enough to debug with, so pdbs have been of limited value). Please revert all the other files so that the impact is kept smaller.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org