Re: Review Request 70060: Updated ReviewBot to verify reviews by checking for updates recursively.

[Mesos Reviewbot <re...@mesos.apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70060/#review213316
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70060]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Feb. 28, 2019, 6:53 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70060/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2019, 6:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-4599
>     https://issues.apache.org/jira/browse/MESOS-4599
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If any of the dependent reviews has an updated diff or dependency, it
> now triggers the ReviewBot. Previously only updates to the tail
> review in the chain triggered the ReviewBot.
> 
> 
> Diffs
> -----
> 
>   support/verify-reviews.py f03869abd74e920283bbb2acc9c71f5f0f30e554 
> 
> 
> Diff: https://reviews.apache.org/r/70060/diff/2/
> 
> 
> Testing
> -------
> 
> ?  mesos git:(vinod/reviewbot_recursive_diff_time) ? ./support/verify-reviews.py -u mesos-review -p foo --skip-verify
> Checking if review: 65835 needs verification
> Skipping blocking review 65835
> Checking if review: 65836 needs verification
> Latest review timestamp: 2018-02-28 14:43:21
> Latest diff timestamp: 2018-02-28 13:55:43
> Dependent review: https://reviews.apache.org/api/review-requests/65835/ 
> Latest diff timestamp: 2018-02-28 13:55:32
> Dependent review: https://reviews.apache.org/api/review-requests/65834/ 
> Latest diff timestamp: 2018-02-28 13:55:22
> Checking if review: 65820 needs verification
> Skipping blocking review 65820
> Checking if review: 65821 needs verification
> Skipping blocking review 65821
> Checking if review: 65847 needs verification
> Latest review timestamp: 2018-03-01 02:54:04
> Latest diff timestamp: 2018-02-28 20:22:13
> Dependent review: https://reviews.apache.org/api/review-requests/65845/ 
> Latest diff timestamp: 2018-02-28 19:57:14
> Dependent review: https://reviews.apache.org/api/review-requests/65844/ 
> Latest diff timestamp: 2018-02-28 19:57:08
> Dependent review: https://reviews.apache.org/api/review-requests/65821/ 
> Latest diff timestamp: 2018-02-28 19:57:02
> Dependent review: https://reviews.apache.org/api/review-requests/65820/ 
> ...
> ...
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>