You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/04/26 19:15:06 UTC
[GitHub] [daffodil] dependabot[bot] opened a new pull request, #791: Bump actions/setup-java from 3.1.1 to 3.2.0
dependabot[bot] opened a new pull request, #791:
URL: https://github.com/apache/daffodil/pull/791
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.1.1 to 3.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-java/releases">actions/setup-java's releases</a>.</em></p>
<blockquote>
<h2>v3.2.0</h2>
<p>This release introduces dependency caching support for sbt (<a href="https://github-redirect.dependabot.com/actions/setup-java/pull/302">actions/setup-java#302</a>).</p>
<h3>Caching sbt dependencies</h3>
<pre lang="yml"><code>steps:
- uses: actions/checkout@v3
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
cache: 'sbt'
- name: Build with SBT
run: sbt package
</code></pre>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/setup-java/commit/4fe61d24fe5472910b93bdeffb8aad49f979d862"><code>4fe61d2</code></a> [README] Add sbt as supported package manager for caching (<a href="https://github-redirect.dependabot.com/actions/setup-java/issues/322">#322</a>)</li>
<li><a href="https://github.com/actions/setup-java/commit/055250a105d999e8a448b9b80138d7d4acc7cf7c"><code>055250a</code></a> Add CODE_OF_CONDUCT (<a href="https://github-redirect.dependabot.com/actions/setup-java/issues/318">#318</a>)</li>
<li><a href="https://github.com/actions/setup-java/commit/0ed94a56789e7ec6897b1ec1c1e60d459a6baa5f"><code>0ed94a5</code></a> Add SBT in cache managers. (<a href="https://github-redirect.dependabot.com/actions/setup-java/issues/302">#302</a>)</li>
<li>See full diff in <a href="https://github.com/actions/setup-java/compare/v3.1.1...v3.2.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] tuxji merged pull request #791: Bump actions/setup-java from 3.1.1 to 3.2.0
Posted by GitBox <gi...@apache.org>.
tuxji merged PR #791:
URL: https://github.com/apache/daffodil/pull/791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on pull request #791: Bump actions/setup-java from 3.1.1 to 3.2.0
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #791:
URL: https://github.com/apache/daffodil/pull/791#issuecomment-1111211652
v3.2.0 adds support for caching dependencies in sbt: https://github.com/actions/setup-java#caching-packages-dependencies=
Any thoughts on if we should add `cache: sbt` to our setup-java job to enable that? I'm not sure how much of a difference it would make in the build though--downloading dependencies is probably a small fraction of our job time due to all the tests we run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on pull request #791: Bump actions/setup-java from 3.1.1 to 3.2.0
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #791:
URL: https://github.com/apache/daffodil/pull/791#issuecomment-1112165960
As expected, the sbt cache doesn't seem to speed anything up significantly, but it the setup-java job only takes a few seconds and restores a cache that's ~238 MB, so a pretty big size. Probably worth keeping the cache just to avoid downloading that much.
+1
- [X] **Do all automated continuous integration checks pass?**
Yes
- [X] **Is the update a patch, minor, or major update?**
Minor update, adds sbt cache support--main.yaml is modified to use the new option
- [X] **Is the license still compatible with ASF License Policy?**
Yes, still MIT
- [X] **Have any changes been made to LICENSE/NOTICE files that need to be incorporated?**
No, but not applicable, we do not distribute
- [X] **Have any transitive dependencies been added or changed?**
No, but not applicable, we do not distribute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] tuxji commented on pull request #791: Bump actions/setup-java from 3.1.1 to 3.2.0
Posted by GitBox <gi...@apache.org>.
tuxji commented on PR #791:
URL: https://github.com/apache/daffodil/pull/791#issuecomment-1111245291
I agree adding cache: sbt might save a negligible amount of time but I think it's worth making the change to find out anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org