Re: Scope for Next Release (1.4.0?)

[Mike Jumper <mj...@apache.org>]

On Sat, May 15, 2021 at 1:04 PM Nick Couchman <ni...@gmail.com> wrote:
>
> On Fri, May 14, 2021 at 4:15 PM Mike Jumper <mj...@apache.org> wrote:
>
> > On Fri, May 14, 2021 at 1:03 PM Mike Jumper <mj...@apache.org> wrote:
> >
> > > On Thu, May 13, 2021 at 1:34 PM Nick Couchman <nick.e.couchman@gmail.com
> > >
> > > wrote:
> > >
> > >> Hey, everyone,
> > >> Just doing my usual push to try to finalize scope for the next release,
> > >> which I'm guessing we'll call 1.4.0, and start to target a release date.
> > >> I'm currently looking at end of June/beginning of July.
> > >>
> > >> So far, the following issues have already been implemented/fixed:
> > >>
> > >> GUACAMOLE-1190 (Fix guacd binding to IPv6)
> > >> GUACAMOLE-1298 (Enforce size limits with reverse proxy)
> > >> GUACAMOLE-1307 (FreeRDP 2.3.1 build fixes)
> > >> GUACAMOLE-747 (Document branding)
> > >> GUACAMOLE-1025 (Allow QuickConnect to block connection parameters)
> > >> GUACAMOLE-1060 (Handle Nginx body size limit)
> > >> GUACAMOLE-1128 (Add auto-create options in Docker script)
> > >> GUACAMOLE-1133 (Fix VNC connections to MacOS)
> > >> GUACAMOLE-1160 (Fix French translations)
> > >> GUACAMOLE-1174 (Support connecting to K8s Pods with exec)
> > >> GUACAMOLE-1191 (Disable caches not supported by FreeRDP)
> > >> GUACAMOLE-1201 (Fix audio input rate issues)
> > >> GUACAMOLE-1207 (Portuguese translations)
> > >> GUACAMOLE-1259 (Fix double-free in RDP connect)
> > >> GUACAMOLE-1263 (Fix double-free in VNC disconnect)
> > >> GUACAMOLE-1265 (Update Japanese translations)
> > >> GUACAMOLE-1277 (Fix character in French Belgian AZERTY layout)
> > >> GUACAMOLE-1283 (Fix issue with legacy RDP encryption)
> > >> GUACAMOLE-1299 (Fix for session expiration race)
> > >> GUACAMOLE-1302 (Add support for forcing lossless compression)
> > >> GUACAMOLE-1305 (Fix issue with Portuguese Brazilian keyboard layout)
> > >> GUACAMOLE-1316 (Fix OpenID issue on Docker startup script)
> > >> GUACAMOLE-1317 (Fix OpenJDK build issues with later versions)
> > >> GUACAMOLE-1337 (Clean up trailing white space)
> > >> GUACAMOLE-1055 (Improve Russian OSK Latin symbol support)
> > >> GUACAMOLE-1185 (Fix typo in audio-input file)
> > >> GUACAMOLE-1225 (Fix simple typo)
> > >> GUACAMOLE-1227 (Fix libvncclient 0.9.7 build failure)
> > >> GUACAMOLE-1254 (Support util-linux libuuid)
> > >> GUACAMOLE-1334 (Fix OpenID translation mismatch)
> > >>
> > >> In addition to those, I'd nominate the following issues that are
> > >> in-progress to be included:
> > >> GUACAMOLE-1292 (Prompt before closing window)
> > >> GUACAMOLE-1252 (Allow RADIUS NAS IP to be configured)
> > >> GUACAMOLE-1199 (Fix JDBC issue data disappears with TOTP)
> > >> GUACAMOLE-1245 (Add client parameter for WoL port)
> > >> GUACAMOLE-944 (Allow search username in non-DN format)
> > >> GUACAMOLE-343 (Add fields for explicitly disabling recording)
> > >> GUACAMOLE-996 (Add support for group filter)
> > >> GUACAMOLE-680 (Implement logout hook handler)
> > >>
> > >> Beyond those, there are several that have been in progress for a while,
> > >> but
> > >> without much attention, that we could try to include if we can get
> > >> progress
> > >> from the authors (which could include me on a few of these):
> > >> GUACAMOLE-1219 (Limit TOTP by group membership)
> > >> GUACAMOLE-1130 (Limit retrieval of LDAP attributes)
> > >> GUACAMOLE-1099 (Add support for Docker secrets for LDAP)
> > >> GUACAMOLE-1097 (Update Spanish translations)
> > >> GUACAMOLE-536 (Support LDAP direct binding)
> > >> GUACAMOLE-1006 (Implement List properties)
> > >> GUACAMOLE-1056 (Support TOTP time drift tracking)
> > >> GUACAMOLE-968 (Norwegian keymap)
> > >> GUACAMOLE-1005 (Docker support for Tomcat RemoteIP valve)
> > >> GUACAMOLE-1267 (Support VNC disable remote input)
> > >> GUACAMOLE-141 (Full support for SSH keyboard-interactive)
> > >> GUACAMOLE-1113 (Support right modifiers for SSH/Telnet)
> > >> GUACAMOLE-1047 (Notify connecting client on unknown connection ID)
> > >> GUACAMOLE-951 (Support RDP Keyboard Type)
> > >> GUACAMOLE-1094 (Support OpenID overridable response_type)
> > >> GUACAMOLE-124 (Support for FullScreen action)
> > >> GUACAMOLE-577 (Support proxy configuration for LDAP connections)
> > >> GUACAMOLE-989 (Implement keyboard lock support)
> > >>
> > >> Anything we want to knock off the list? Any that we should add?
> > >>
> > >
> > > Checking the commits merged since 1.3.0, I think there are a few issues
> > > missing from the already implemented/included list:
> > >
> > > https://issues.apache.org/jira/browse/GUACAMOLE-770 (Support for
> > > resetting TOTP within UI)
> > > https://issues.apache.org/jira/browse/GUACAMOLE-773 (Update webapp
> > > dependencies)
> > > https://issues.apache.org/jira/browse/GUACAMOLE-890 (Reduce Docker image
> > > privileges)
> > > https://issues.apache.org/jira/browse/GUACAMOLE-986 (Properly document
> > > non-nullable types)
> > > https://issues.apache.org/jira/browse/GUACAMOLE-1204 (RDP support for
> > > touch event pass-through)
> > > https://issues.apache.org/jira/browse/GUACAMOLE-1218
> > (guacamole-auth-json)
> > > https://issues.apache.org/jira/browse/GUACAMOLE-1276 (Offset truncated
> > to
> > > 32 bits in RDP)
> > > https://issues.apache.org/jira/browse/GUACAMOLE-1284
> > > (OPENID_MAX_TOKEN_VALIDITY variable for Docker)
> > > https://issues.apache.org/jira/browse/GUACAMOLE-1291 (Korean
> > translation)
> > > https://issues.apache.org/jira/browse/GUACAMOLE-1339 (Spanish
> > translation
> > > updates)
> > >
> > > Additionally, the following issue was listed as possible to exclude from
> > > scope, but has associated commits merged:
> > >
> > > https://issues.apache.org/jira/browse/GUACAMOLE-1245 (Configuration
> > > option for WoL port)
> > >
> > > I think we should also include the migration away from DocBook, as it
> > > would make the remaining documentation tasks easier and I'm almost done:
> > >
> > > https://issues.apache.org/jira/browse/GUACAMOLE-1347
> > >
> > > I would also like to include the following if there are no objections:
> > >
> > > https://issues.apache.org/jira/browse/GUACAMOLE-956 (Migrate away from
> > > query parameter auth tokens)
> > > https://issues.apache.org/jira/browse/GUACAMOLE-641 (Support for key
> > > vaults)
> > >
> > > Both of the above should be almost complete with the exception of
> > > rebasing, final testing, and documentation.
> > >
> >
> > The top 3 RDP-related issues also look to be low-hanging fruit:
> >
> > https://issues.apache.org/jira/browse/GUACAMOLE-478 <-- Simple newline
> > translation
> > https://issues.apache.org/jira/browse/GUACAMOLE-801 <-- Likely already
> > fixed
> > https://issues.apache.org/jira/browse/GUACAMOLE-1203 <-- May also already
> > be fixed
> >
> >
> I'm aligned with these and I've gone through and tagged each of these
> issues with the 1.4.0 release. I've started working on a couple of the PRs
> that had comments/changes, and I'll also try to get some reviews done,
> here, soon.
>

Welp, I think enough time has elapsed since this discussion was called
to consider general consensus on scope achieved. ;) I've rechecked the
changes merged to master since 1.3.0 and that those JIRA issues are
properly tagged. Current scope stands at:

https://issues.apache.org/jira/issues/?jql=Project%20%3D%20GUACAMOLE%20AND%20fixVersion%20%3D%201.4.0%20ORDER%20BY%20Status%20ASC%2C%20Watchers%2C%20Votes%2C%20Priority

I'll move forward with creating the "staging/1.4.0" branches and
updating the bases of any relevant PRs.

- Mike