You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by mm...@apache.org on 2021/09/22 14:59:53 UTC

svn commit: r1893514 - /spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/PDFInfo.pm

Author: mmartinec
Date: Wed Sep 22 14:59:53 2021
New Revision: 1893514

URL: http://svn.apache.org/viewvc?rev=1893514&view=rev
Log:
Plugin/PDFInfo.pm: fix the "no such facility warn", triping the t/debug.t

Modified:
    spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/PDFInfo.pm

Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/PDFInfo.pm
URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/PDFInfo.pm?rev=1893514&r1=1893513&r2=1893514&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/PDFInfo.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/PDFInfo.pm Wed Sep 22 14:59:53 2021
@@ -143,7 +143,7 @@ package Mail::SpamAssassin::Plugin::PDFI
 use Mail::SpamAssassin::Plugin;
 use Mail::SpamAssassin::Logger;
 use Mail::SpamAssassin::Util qw(compile_regexp);
-use strict;
+use strict; use feature qw(refaliasing state evalbytes say fc current_sub); no feature qw(indirect);
 use warnings;
 use re 'taint';
 # use bytes;
@@ -406,7 +406,7 @@ sub parsed_metadata {
   my ($self, $opts) = @_;
   my $pms = $opts->{permsgstatus};
 
-  dbg ('warn: get_uri_detail_list() has been called already')
+  dbg ('pdfinfo: get_uri_detail_list() has been called already')
     if exists $pms->{uri_detail_list};
 
   # make sure we have image data read in.



Re: svn commit: r1893514 - /spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/PDFInfo.pm

Posted by Bill Cole <sa...@billmail.scconsult.com>.
On 2021-09-22 at 10:59:53 UTC-0400 (Wed, 22 Sep 2021 14:59:53 -0000)
 <de...@spamassassin.apache.org>
is rumored to have said:

> Author: mmartinec
> Date: Wed Sep 22 14:59:53 2021
> New Revision: 1893514
>
> URL: http://svn.apache.org/viewvc?rev=1893514&view=rev
> Log:
> Plugin/PDFInfo.pm: fix the "no such facility warn", triping the t/debug.t
>
> Modified:
>     spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/PDFInfo.pm
>
> Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/PDFInfo.pm
> URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/PDFInfo.pm?rev=1893514&r1=1893513&r2=1893514&view=diff
> ==============================================================================
> --- spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/PDFInfo.pm (original)
> +++ spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/PDFInfo.pm Wed Sep 22 14:59:53 2021
> @@ -143,7 +143,7 @@ package Mail::SpamAssassin::Plugin::PDFI
>  use Mail::SpamAssassin::Plugin;
>  use Mail::SpamAssassin::Logger;
>  use Mail::SpamAssassin::Util qw(compile_regexp);
> -use strict;
> +use strict; use feature qw(refaliasing state evalbytes say fc current_sub); no feature qw(indirect);

Why?

I believe this will break compatibility with older Perl (<5.22) without actually needing all those 'features.'


-- 
Bill Cole
bill@scconsult.com or billcole@apache.org
(AKA @grumpybozo and many *@billmail.scconsult.com addresses)
Not Currently Available For Hire