You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Dan Fabulich (JIRA)" <ji...@codehaus.org> on 2007/12/08 00:14:57 UTC
[jira] Created: (MSHADE-8) Shade plugin will cheerfully shade your
own classes
Shade plugin will cheerfully shade your own classes
---------------------------------------------------
Key: MSHADE-8
URL: http://jira.codehaus.org/browse/MSHADE-8
Project: Maven 2.x Shade Plugin
Issue Type: Improvement
Reporter: Dan Fabulich
My relocation patterns were initially too relaxed, and so they wound up shading my own classes, rather than just the classes I depend on.
I could imagine somebody wanting to do this, but I think there should probably be a safety check or something to try to help you not do it by accident; it's probably not what you want. (After all, if you wanted your code to be in a different package, wouldn't you have just written it that way to begin with?)
In my case I was working on a Maven plugin; when its classes got shaded, it broke the plugin metadata... definitely not what I wanted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHADE-8) Shade plugin will cheerfully relocate
your own classes
Posted by "Robert Burrell Donkin (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHADE-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=272195#comment-272195 ]
Robert Burrell Donkin commented on MSHADE-8:
--------------------------------------------
IMHO this isn't a bug.
> Shade plugin will cheerfully relocate your own classes
> ------------------------------------------------------
>
> Key: MSHADE-8
> URL: https://jira.codehaus.org/browse/MSHADE-8
> Project: Maven 2.x Shade Plugin
> Issue Type: Improvement
> Affects Versions: 1.0-alpha-15
> Reporter: Dan Fabulich
>
> My relocation patterns were initially too relaxed, and so they wound up relocating my own classes, rather than just the classes I depend on.
> I could imagine somebody wanting to do this, but I think there should probably be a safety check or something to try to help you not do it by accident; it's probably not what you want. (After all, if you wanted your code to be in a different package, wouldn't you have just written it that way to begin with?)
> In my case I was working on a Maven plugin; when its classes got relocated, it broke the plugin metadata... definitely not what I wanted.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSHADE-8) Shade plugin will cheerfully relocate
your own classes
Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHADE-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Fabulich updated MSHADE-8:
------------------------------
Description:
My relocation patterns were initially too relaxed, and so they wound up relocating my own classes, rather than just the classes I depend on.
I could imagine somebody wanting to do this, but I think there should probably be a safety check or something to try to help you not do it by accident; it's probably not what you want. (After all, if you wanted your code to be in a different package, wouldn't you have just written it that way to begin with?)
In my case I was working on a Maven plugin; when its classes got relocated, it broke the plugin metadata... definitely not what I wanted.
was:
My relocation patterns were initially too relaxed, and so they wound up shading my own classes, rather than just the classes I depend on.
I could imagine somebody wanting to do this, but I think there should probably be a safety check or something to try to help you not do it by accident; it's probably not what you want. (After all, if you wanted your code to be in a different package, wouldn't you have just written it that way to begin with?)
In my case I was working on a Maven plugin; when its classes got shaded, it broke the plugin metadata... definitely not what I wanted.
Summary: Shade plugin will cheerfully relocate your own classes (was: Shade plugin will cheerfully shade your own classes)
> Shade plugin will cheerfully relocate your own classes
> ------------------------------------------------------
>
> Key: MSHADE-8
> URL: http://jira.codehaus.org/browse/MSHADE-8
> Project: Maven 2.x Shade Plugin
> Issue Type: Improvement
> Reporter: Dan Fabulich
>
> My relocation patterns were initially too relaxed, and so they wound up relocating my own classes, rather than just the classes I depend on.
> I could imagine somebody wanting to do this, but I think there should probably be a safety check or something to try to help you not do it by accident; it's probably not what you want. (After all, if you wanted your code to be in a different package, wouldn't you have just written it that way to begin with?)
> In my case I was working on a Maven plugin; when its classes got relocated, it broke the plugin metadata... definitely not what I wanted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHADE-8) Shade plugin will cheerfully relocate
your own classes
Posted by "Robert Burrell Donkin (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHADE-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=272205#comment-272205 ]
Robert Burrell Donkin commented on MSHADE-8:
--------------------------------------------
IMHO debugging shade is distinct issue from verification rules for the completed build. Typically, better instrumentation with logging is a better solution to debugging problems than adding extra rules that may catch people expecting otherwise. But it's quite reasonable to want to verify that no original class has been relocated.
Been thinking that it might be useful to track the origins of resources. This would allow (for example) generation of accurate licensing information. This would also allow application of verification rules...
> Shade plugin will cheerfully relocate your own classes
> ------------------------------------------------------
>
> Key: MSHADE-8
> URL: https://jira.codehaus.org/browse/MSHADE-8
> Project: Maven 2.x Shade Plugin
> Issue Type: Improvement
> Affects Versions: 1.0-alpha-15
> Reporter: Dan Fabulich
>
> My relocation patterns were initially too relaxed, and so they wound up relocating my own classes, rather than just the classes I depend on.
> I could imagine somebody wanting to do this, but I think there should probably be a safety check or something to try to help you not do it by accident; it's probably not what you want. (After all, if you wanted your code to be in a different package, wouldn't you have just written it that way to begin with?)
> In my case I was working on a Maven plugin; when its classes got relocated, it broke the plugin metadata... definitely not what I wanted.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSHADE-8) Shade plugin will cheerfully relocate
your own classes
Posted by "Mauro Talevi (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHADE-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mauro Talevi updated MSHADE-8:
------------------------------
Affects Version/s: 1.0-alpha-15
Fix Version/s: 1.0-beta-1
> Shade plugin will cheerfully relocate your own classes
> ------------------------------------------------------
>
> Key: MSHADE-8
> URL: http://jira.codehaus.org/browse/MSHADE-8
> Project: Maven 2.x Shade Plugin
> Issue Type: Improvement
> Affects Versions: 1.0-alpha-15
> Reporter: Dan Fabulich
> Fix For: 1.0-beta-1
>
>
> My relocation patterns were initially too relaxed, and so they wound up relocating my own classes, rather than just the classes I depend on.
> I could imagine somebody wanting to do this, but I think there should probably be a safety check or something to try to help you not do it by accident; it's probably not what you want. (After all, if you wanted your code to be in a different package, wouldn't you have just written it that way to begin with?)
> In my case I was working on a Maven plugin; when its classes got relocated, it broke the plugin metadata... definitely not what I wanted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHADE-8) Shade plugin will cheerfully relocate
your own classes
Posted by "Dan Fabulich (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHADE-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=272199#comment-272199 ]
Dan Fabulich commented on MSHADE-8:
-----------------------------------
I filed this issue and I agree that it's an enhancement, but I don't think it should just be closed out.
Relocation patterns are very difficult to debug properly; a little more sanity checking would make Shade a lot more useable.
> Shade plugin will cheerfully relocate your own classes
> ------------------------------------------------------
>
> Key: MSHADE-8
> URL: https://jira.codehaus.org/browse/MSHADE-8
> Project: Maven 2.x Shade Plugin
> Issue Type: Improvement
> Affects Versions: 1.0-alpha-15
> Reporter: Dan Fabulich
>
> My relocation patterns were initially too relaxed, and so they wound up relocating my own classes, rather than just the classes I depend on.
> I could imagine somebody wanting to do this, but I think there should probably be a safety check or something to try to help you not do it by accident; it's probably not what you want. (After all, if you wanted your code to be in a different package, wouldn't you have just written it that way to begin with?)
> In my case I was working on a Maven plugin; when its classes got relocated, it broke the plugin metadata... definitely not what I wanted.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHADE-8) Shade plugin will cheerfully relocate
your own classes
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSHADE-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=271962#comment-271962 ]
Benson Margulies commented on MSHADE-8:
---------------------------------------
I don't think that this is a bug. Does anyone else who watches MSHADE think that this is a bug? Absent other commentary, 'enhancement' or 'closed'.
> Shade plugin will cheerfully relocate your own classes
> ------------------------------------------------------
>
> Key: MSHADE-8
> URL: https://jira.codehaus.org/browse/MSHADE-8
> Project: Maven 2.x Shade Plugin
> Issue Type: Improvement
> Affects Versions: 1.0-alpha-15
> Reporter: Dan Fabulich
>
> My relocation patterns were initially too relaxed, and so they wound up relocating my own classes, rather than just the classes I depend on.
> I could imagine somebody wanting to do this, but I think there should probably be a safety check or something to try to help you not do it by accident; it's probably not what you want. (After all, if you wanted your code to be in a different package, wouldn't you have just written it that way to begin with?)
> In my case I was working on a Maven plugin; when its classes got relocated, it broke the plugin metadata... definitely not what I wanted.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSHADE-8) Shade plugin will cheerfully relocate
your own classes
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHADE-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brett Porter updated MSHADE-8:
------------------------------
Fix Version/s: (was: 1.0-beta-2)
> Shade plugin will cheerfully relocate your own classes
> ------------------------------------------------------
>
> Key: MSHADE-8
> URL: http://jira.codehaus.org/browse/MSHADE-8
> Project: Maven 2.x Shade Plugin
> Issue Type: Improvement
> Affects Versions: 1.0-alpha-15
> Reporter: Dan Fabulich
>
> My relocation patterns were initially too relaxed, and so they wound up relocating my own classes, rather than just the classes I depend on.
> I could imagine somebody wanting to do this, but I think there should probably be a safety check or something to try to help you not do it by accident; it's probably not what you want. (After all, if you wanted your code to be in a different package, wouldn't you have just written it that way to begin with?)
> In my case I was working on a Maven plugin; when its classes got relocated, it broke the plugin metadata... definitely not what I wanted.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira