You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/19 18:44:24 UTC
[GitHub] [iceberg] findepi opened a new pull request, #5799: Serialize statistics inside Table Metadata
findepi opened a new pull request, #5799:
URL: https://github.com/apache/iceberg/pull/5799
`TableMetadataParser.toJson` now serializes table statistics. This
completes the read path from JSON.
Extracted from https://github.com/apache/iceberg/pull/4741 / https://github.com/apache/iceberg/pull/5794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #5799: Core: Serialize statistics files in TableMetadata
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #5799:
URL: https://github.com/apache/iceberg/pull/5799#issuecomment-1253032753
Thanks, @findepi!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5799: Serialize statistics inside Table Metadata
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5799:
URL: https://github.com/apache/iceberg/pull/5799#discussion_r974774179
##########
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##########
@@ -225,6 +226,12 @@ public static void toJson(TableMetadata metadata, JsonGenerator generator) throw
}
generator.writeEndArray();
+ generator.writeArrayFieldStart(STATISTICS);
Review Comment:
Can you also add deserialization? Generally when we update a parser we want to update both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on pull request #5799: Serialize statistics inside Table Metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on PR #5799:
URL: https://github.com/apache/iceberg/pull/5799#issuecomment-1251465497
@rdblue this should be ready to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #5799: Core: Serialize statistics files in TableMetadata
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #5799:
URL: https://github.com/apache/iceberg/pull/5799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on a diff in pull request #5799: Serialize statistics inside Table Metadata
Posted by GitBox <gi...@apache.org>.
findepi commented on code in PR #5799:
URL: https://github.com/apache/iceberg/pull/5799#discussion_r974970624
##########
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##########
@@ -225,6 +226,12 @@ public static void toJson(TableMetadata metadata, JsonGenerator generator) throw
}
generator.writeEndArray();
+ generator.writeArrayFieldStart(STATISTICS);
Review Comment:
Deserialization already exists.
https://github.com/apache/iceberg/blob/fca6101f5847ee27feaa5aeb78fe25110e1af6a9/core/src/main/java/org/apache/iceberg/TableMetadataParser.java#L466
Was added in https://github.com/apache/iceberg/pull/5450
The fact serialization was not covered was an omission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] findepi commented on pull request #5799: Core: Serialize statistics files in TableMetadata
Posted by GitBox <gi...@apache.org>.
findepi commented on PR #5799:
URL: https://github.com/apache/iceberg/pull/5799#issuecomment-1253513012
thanks for the merge @rdblue !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org