You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/13 10:39:18 UTC
[GitHub] [shardingsphere] tristaZero opened a new issue #9018: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
tristaZero opened a new issue #9018:
URL: https://github.com/apache/shardingsphere/issues/9018
### Target
- Collate SQL definition of `ROLLBACK` to make SQL definition of `Apache ShardingSphere` the same with Oracle's.
- Add a test case
### How
1. Compare `ROLLBACK` definition in [Oficial SQL Doc](https://www.postgresql.org/docs/12/index.html) and [ShardingSphere SQL Doc](https://github.com/apache/shardingsphere/tree/master/shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/antlr4/imports/postgresql)
2. If there is any difference in ShardingSphere SQL Doc, please correct them referring to Official SQL Doc (**g4 file of ANTLR**)
3. Run `mvn install shardingsphere-sql-parser-oracle`
4. Check whether there are any exceptions. If exists, please fix them. (Please pay attention to `xxxVisitor.class`)
5. Add new corresponding SQL case in `shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/resources/sql` and expected parsed result in `shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/resources/case`
6. Run SQLParserParameterizedTest (`shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/engine/SQLParserParameterizedTest.java`).
### Tips
- Since this issue is a child one of #6480, I guess the PRs relevant to #6480 will give you some examples or hints.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on issue #9018: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #9018:
URL: https://github.com/apache/shardingsphere/issues/9018#issuecomment-759383181
Hi @ThanoshanMV Welcome. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on issue #9018: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on issue #9018:
URL: https://github.com/apache/shardingsphere/issues/9018#issuecomment-759382207
Hi, I would like to work on this issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero closed issue #9018: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #9018:
URL: https://github.com/apache/shardingsphere/issues/9018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on issue #9018: [SQL Definition Collation][Oracle]Collate the SQL definition of ROLLBACK
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on issue #9018:
URL: https://github.com/apache/shardingsphere/issues/9018#issuecomment-760875399
@tristaZero I've gone through [contributor guide](https://shardingsphere.apache.org/community/en/contribute/contributor/) and set up the project. In `shardingsphere/shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle`, I ran `mvn install` and got this error message. Issue is `Could not resolve dependencies for project org.apache.shardingsphere:shardingsphere-sql-parser-oracle:jar:5.0.0-RC1-SNAPSHOT`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org