You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "cheng (JIRA)" <ji...@apache.org> on 2018/12/17 15:45:00 UTC
[jira] [Created] (DIRMINA-1098) Hello, I have found a bug in
2.0.19
cheng created DIRMINA-1098:
------------------------------
Summary: Hello, I have found a bug in 2.0.19
Key: DIRMINA-1098
URL: https://issues.apache.org/jira/browse/DIRMINA-1098
Project: MINA
Issue Type: Bug
Components: Core
Affects Versions: 2.0.19
Reporter: cheng
Fix For: 3.0.0-trunk
First of all, I want to say, I have found a bug in version 2.0.19, which is no problem in version 2.0.16. Comparing the org.apache.mina.filter.ssl.SslHandle.java betwen two version, in the unwrap() method, handshakeStatus is a temporary variable in version 2.0.16, and this temporary variable is changed to a member variable in 2.0.19.
The problem is that when the session is established, if the server immediately sends a message, the handshakeStatus will remain in the NOT_HANDSHAKING state at this time, and will never go to FINISHED.
{code:java}
//2.0.19 has a bug
private SSLEngineResult unwrap() throws SSLException {
***
SSLEngineResult res;
Status status;
do {
***
handshakeStatus = res.getHandshakeStatus();
***
}{code}
{code:java}
//2.0.16 is ok
private SSLEngineResult unwrap() throws SSLException {
***
SSLEngineResult res;
Status status;
HandshakeStatus handshakeStatus = null;
do {
***
handshakeStatus = res.getHandshakeStatus();
***
}{code}
The following is my positioning process, please refer to.
1. In the handshake method of SslHandler.java, add a sentence to print.
{code:java}
//2.0.19
/void handshake(NextFilter nextFilter) throws SSLException {
for (;;) {
switch (handshakeStatus) {
System.out.println(handshakeStatus);
case FINISHED:
{code}
When creating an ssl connection, the 2.0.19 print sequence is as follows: NOT_HANDSHAKING
NEED_UNWRAP
NEED_UNWRAP
NEED_TASK
NEED_WRAP
NEED_WRAP
NEED_WRAP
NEED_UNWRAP
NEED_UNWRAP
NEED_UNWRAP
NEED_UNWRAP
{color:#FF0000} NOT_HANDSHAKING{color}
{color:#FF0000} NOT_HANDSHAKING {color}
And 2.0.16 can be ended correctly.
NEED_WRAP
NEED_UNWRAP
NEED_UNWRAP
NEED_TASK
NEED_WRAP
NEED_WRAP
NEED_WRAP
NEED_UNWRAP
NEED_UNWRAP
NEED_UNWRAP
NEED_UNWRAP
FINISHED
2. We can find thar there is a problem in the last NEED_UNWRAP. By debugging the code in 2.0.16 and 2.0.19 respectively, When the unwrapHandshake method is tracked , the handshakeStatus variable is changed after the unwrap() method. However, when viewing the unwrap() method, there is no reassignment of the variables to the handshakeStatus, so I guess the reference address was changed. By printing the memory address of the handshakeStatus, it was found that the change did occur. As for where to change, I didn't understand at the moment, so I compared the modification points of the SslHandler.java files in 2.0.16 and 2.0.19 , then found that the temporary variable in 2.0.19 was wrongly changed to member variable ，maybe due to the name is same.
{code:java}
//2.0.19
private SSLEngineResult.Status unwrapHandshake(NextFilter nextFilter)
throws SSLException {
***
// If handshake finished, no data was produced, and the status is still
// ok, try to unwrap more
if ((handshakeStatus == SSLEngineResult.HandshakeStatus.FINISHED)
&& (res.getStatus() == SSLEngineResult.Status.OK)
&& inNetBuffer.hasRemaining()) {
res = unwrap();
***
{code}
3. Try to change handshakeStatus to a temporary variable, I found that the problem was fixed.
{code:java}
//2.0.19
private SSLEngineResult unwrap() throws SSLException {
***
SSLEngineResult res;
Status status;
HandshakeStatus handshakeStatus = null;
do {
***
handshakeStatus = res.getHandshakeStatus();
***
}
{code}
Therefore, please help to track down the problem and solve it as soon as possible. This problem is conditional appearance, thank you.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)