[jira] Commented: (THRIFT-482) build.xml does not specify a target version for compiled java classes

["David Reiss (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705876#action_12705876 ] 

David Reiss commented on THRIFT-482:
------------------------------------

What is the downside of this patch?  I assume that java would not generate incompatible class files unless there was something to gain.

> build.xml does not specify a target version for compiled java classes
> ---------------------------------------------------------------------
>
>                 Key: THRIFT-482
>                 URL: https://issues.apache.org/jira/browse/THRIFT-482
>             Project: Thrift
>          Issue Type: Bug
>         Environment: java version "1.6.0_13"
> Java(TM) SE Runtime Environment (build 1.6.0_13-b03)
> Java HotSpot(TM) 64-Bit Server VM (build 11.3-b02, mixed mode)
>            Reporter: Jarret Falkner
>         Attachments: java5_target.patch
>
>
> When building thrift in a java 6 environment, the packaged libthrift.jar contains classes for version 6 java.  The compile target in build.xml should make java version 5 class files to maintain compatibility with earlier runtime environments.
> The attached patch should update build.xml with the desired behavior.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.