You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/01 20:32:00 UTC
[jira] [Work logged] (BEAM-14012) Add go fmt CI check
[ https://issues.apache.org/jira/browse/BEAM-14012?focusedWorklogId=734908&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-734908 ]
ASF GitHub Bot logged work on BEAM-14012:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/22 20:31
Start Date: 01/Mar/22 20:31
Worklog Time Spent: 10m
Work Description: jrmccluskey opened a new pull request #16978:
URL: https://github.com/apache/beam/pull/16978
Adds a `go fmt` check to the Go GitHub actions, failing the build if a formatter run alters the code.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 734908)
Remaining Estimate: 0h
Time Spent: 10m
> Add go fmt CI check
> -------------------
>
> Key: BEAM-14012
> URL: https://issues.apache.org/jira/browse/BEAM-14012
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Danny McCormick
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Right now, we occasionally notice that checked in files have not been formatted properly (e.g. [https://github.com/apache/beam/pull/16973).] It would be nice to catch these as a precommit check (it could be something as simple as a quick Actions or Jira job that runs:
> ```
> go fmt sdks/go/...
> git diff-index --quiet HEAD – || (echo "Run go fmt before checking in changes" && exit 1)}}
> {{```}}
> That way we push the work to the original authors and let robots enforce linting :)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)