[jira] [Issue Comment Deleted] (MYRIAD-228) Duplicated NM opts

["Klaus Ma (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MYRIAD-228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Klaus Ma updated MYRIAD-228:
----------------------------
    Comment: was deleted

(was: It seems we should clear environments when generate command, draft code diff:

{code}
index db945ec..424ecf6 100644
--- a/myriad-scheduler/src/main/java/org/apache/myriad/scheduler/NMExecutorCLGenImpl.java
+++ b/myriad-scheduler/src/main/java/org/apache/myriad/scheduler/NMExecutorCLGenImpl.java
@@ -68,14 +68,17 @@ public class NMExecutorCLGenImpl implements ExecutorCommandLineGenerator {

   protected void generateEnvironment(ServiceResourceProfile profile, NMPorts ports) {
+    // clear old environment.
+    environment.clear();
+
     //yarnEnvironemnt configuration from yaml file
     Map<String, String> yarnEnvironmentMap = cfg.getYarnEnvironment();
     if (yarnEnvironmentMap != null) {
{code})

> Duplicated NM opts
> ------------------
>
>                 Key: MYRIAD-228
>                 URL: https://issues.apache.org/jira/browse/MYRIAD-228
>             Project: Myriad
>          Issue Type: Bug
>            Reporter: Klaus Ma
>
> In {{NMExecutorCLGenImpl.java:addYarnNodemanagerOpt}}, it keep appending NM Opts. It'll make arguments too long.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)