[GitHub] [rocketmq] xdkxlk commented on a diff in pull request #5306: [ISSUE #5305] fix proxy TopicRouteService cache bug

[GitBox <gi...@apache.org>]

xdkxlk commented on code in PR #5306:
URL: https://github.com/apache/rocketmq/pull/5306#discussion_r994334559


##########
proxy/src/main/java/org/apache/rocketmq/proxy/service/route/TopicRouteService.java:
##########
@@ -88,6 +89,15 @@ public TopicRouteService(MQClientAPIFactory mqClientAPIFactory) {
                         throw e;
                     }
                 }
+
+                @Override public @Nullable MessageQueueView reload(@NonNull String key,
+                    @NonNull MessageQueueView oldValue) throws Exception {
+                    try {
+                        return load(key);
+                    } catch (Exception e) {

Review Comment:
   Add a log here is better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org