[PR] Polish up some code from recent changes [accumulo]

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii opened a new pull request, #3979:
URL: https://github.com/apache/accumulo/pull/3979

   * Use simpler expression for non-digits in regex pattern
   * Keep only the minimal code needed for the deprecated "chopped" column
   * Fix comment about version 3.1 (use dot, not comma)
   * Remove unnecessary 'var ignored = ' which caused unused variable warnings in some IDEs; this might cause warnings about unused return values in other IDEs, but I'm not sure the ideal way to address that at this point; for now, this change keeps us at 0 warnings in Eclipse with default settings, except those from thrift and the unavoidable ones from Eclipse's incorrect handling of forRemoval deprecations, and this is also consistent with our current coding style (we don't use ignored variable declarations anywhere else)
   * Make slight improvements to upgrader code to identify and retrieve the oldest upgradable version
   * Replace static imports to inner classes with non-static imports, as this results in the same code usage; static is unnecessary for these


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Polish up some code from recent changes [accumulo]

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii commented on PR #3979:
URL: https://github.com/apache/accumulo/pull/3979#issuecomment-1831337424

   Rebased on main to fix conflicts. Some stuff was fixed already, some new stuff showed up. I also made an attempt to merge this into the elasticity branch, to see what problems might occur, and I ran into issues related to the fact that the elasticity branch seems to have dropped some (but curiously, not all) of the code needed to support upgrades from 2.1... which is very confusing to me (Note: 2.1 is the current LTM, so any new version should support upgrading from it, until there's a newer LTM).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Polish up some code from recent changes [accumulo]

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii merged PR #3979:
URL: https://github.com/apache/accumulo/pull/3979


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org