You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by neilalex <gi...@git.apache.org> on 2018/01/22 21:01:28 UTC
[GitHub] spark pull request #20352: [SPARK-21727][R] Allow multi-element atomic vecto...
GitHub user neilalex opened a pull request:
https://github.com/apache/spark/pull/20352
[SPARK-21727][R] Allow multi-element atomic vector as column type in SparkR DataFrame
## What changes were proposed in this pull request?
A fix to https://issues.apache.org/jira/browse/SPARK-21727, "Operating on an ArrayType in a SparkR DataFrame throws error"
## How was this patch tested?
- Ran tests at R\pkg\tests\run-all.R (see below attached results)
- Tested the following lines in SparkR, which now seem to execute without error:
```
indices <- 1:4
myDf <- data.frame(indices)
myDf$data <- list(rep(0, 20))
mySparkDf <- as.DataFrame(myDf)
collect(mySparkDf)
```
[2018-01-22 SPARK-21727 Test Results.txt](https://github.com/apache/spark/files/1653535/2018-01-22.SPARK-21727.Test.Results.txt)
@felixcheung @yanboliang @sun-rui @shivaram
_The contribution is my original work and I license the work to the project under the project’s open source license_
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neilalex/spark neilalex-sparkr-arraytype
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20352.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20352
----
commit 6bdf687511d19e26c9c5a23b32e1ac6b3ea763e4
Author: neilalex <ne...@...>
Date: 2018-01-05T03:53:30Z
Check if an atomic R type is actually a vector of length > 1, and treat it as an array if so.
commit f8ae69853b4529ad1c9b32fa705ab27426c52b66
Author: neilalex <ne...@...>
Date: 2018-01-22T03:15:02Z
Use is.atomic(object) to check type
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by neilalex <gi...@git.apache.org>.
Github user neilalex commented on the issue:
https://github.com/apache/spark/pull/20352
sure
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20352: [SPARK-21727][R] Allow multi-element atomic vecto...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20352
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20352
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20352
That looks good. Thanks! We work together on this fix so I’m pretty confident about this change.
On a side note assuming we push this to 2.3 should we add the behavior change to the R programming guide migration guide section?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20352
**[Test build #86494 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86494/testReport)** for PR 20352 at commit [`f8ae698`](https://github.com/apache/spark/commit/f8ae69853b4529ad1c9b32fa705ab27426c52b66).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20352
**[Test build #86494 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86494/testReport)** for PR 20352 at commit [`f8ae698`](https://github.com/apache/spark/commit/f8ae69853b4529ad1c9b32fa705ab27426c52b66).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/20352
@neilalex Can you add the code snippet in the PR description as a new test case ? That way we will ensure this behavior is tested going forward
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20352
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by neilalex <gi...@git.apache.org>.
Github user neilalex commented on the issue:
https://github.com/apache/spark/pull/20352
@shivaram alright, should be good with the tests now -- let me know how it seems
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20352
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86494/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20352
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86500/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20352
**[Test build #86500 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86500/testReport)** for PR 20352 at commit [`01fc9e1`](https://github.com/apache/spark/commit/01fc9e1539d096a67284600f843f1ed4cd397152).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/20352
Thanks @neilalex - Change LGTM. Lets also see if @felixcheung has any comments.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20352
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by shivaram <gi...@git.apache.org>.
Github user shivaram commented on the issue:
https://github.com/apache/spark/pull/20352
Jenkins, ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/20352
merged to master/2.3. we could revisit migration guide if necessary.
thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by neilalex <gi...@git.apache.org>.
Github user neilalex commented on the issue:
https://github.com/apache/spark/pull/20352
@felixcheung @yanboliang @shivaram thank you for your guidance!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20352
**[Test build #86500 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86500/testReport)** for PR 20352 at commit [`01fc9e1`](https://github.com/apache/spark/commit/01fc9e1539d096a67284600f843f1ed4cd397152).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20352: [SPARK-21727][R] Allow multi-element atomic vector as co...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20352
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org