You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by GitBox <gi...@apache.org> on 2020/10/01 20:00:19 UTC

[GitHub] [isis-antora] ahus1 opened a new pull request #3: ISIS-2368: porting lightbox feature for figures without an anchor

ahus1 opened a new pull request #3:
URL: https://github.com/apache/isis-antora/pull/3


   To allow for the lightbox effect, this PR adds the necessary JavaScript as in https://gitlab.com/antora/antora-ui-default/-/merge_requests/126
   
   The Antora UI Bundle for ISIS will replace this with a JavaScript that opens the image in a lightbox. Another click on the X in the upper right or the image itself closes the lightbox. 
   
   The PR https://github.com/apache/isis/pull/226 will then clean up the ISIS docs from self-linking images.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [isis-antora] andi-huber edited a comment on pull request #3: ISIS-2368: porting lightbox feature for figures without an anchor

Posted by GitBox <gi...@apache.org>.
andi-huber edited a comment on pull request #3:
URL: https://github.com/apache/isis-antora/pull/3#issuecomment-702540487


   Great stuff! Apache Isis Site Preview is up to date: https://apache-isis-committers.github.io/isis-nightly/docs/latest/what-is-apache-isis/isis-in-pictures.html
   
   I noticed that the lightboxes are not centered with respect to the browser window. So with above example, the images are rendered too far right, partly outside the viewport.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [isis-antora] andi-huber commented on pull request #3: ISIS-2368: porting lightbox feature for figures without an anchor

Posted by GitBox <gi...@apache.org>.
andi-huber commented on pull request #3:
URL: https://github.com/apache/isis-antora/pull/3#issuecomment-702540487


   Great stuff! Apache Isis Site Preview is up to date: https://apache-isis-committers.github.io/isis-nightly/docs/latest/what-is-apache-isis/isis-in-pictures.html
   
   I noticed that the lightboxes are not centered with respect to the the browser window. So with above example, the images are rendered too far right, partly outside the viewport.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [isis-antora] ahus1 commented on pull request #3: ISIS-2368: porting lightbox feature for figures without an anchor

Posted by GitBox <gi...@apache.org>.
ahus1 commented on pull request #3:
URL: https://github.com/apache/isis-antora/pull/3#issuecomment-702556065


   @andi-huber - new PR available: https://github.com/apache/isis-antora/pull/4


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [isis-antora] ahus1 commented on pull request #3: ISIS-2368: porting lightbox feature for figures without an anchor

Posted by GitBox <gi...@apache.org>.
ahus1 commented on pull request #3:
URL: https://github.com/apache/isis-antora/pull/3#issuecomment-702551088


   Hm, sorry I broke this for these wide images. Will submit another PR today.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [isis-antora] andi-huber merged pull request #3: ISIS-2368: porting lightbox feature for figures without an anchor

Posted by GitBox <gi...@apache.org>.
andi-huber merged pull request #3:
URL: https://github.com/apache/isis-antora/pull/3


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org