You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/10 14:59:51 UTC
[GitHub] [airflow] subkanthi opened a new pull request, #22388: Helm support local kubernetes executor
subkanthi opened a new pull request, #22388:
URL: https://github.com/apache/airflow/pull/22388
Helm changes to support LocalKubernetesExecutor
Airflow Docker images dont have the https://github.com/apache/airflow/pull/19729 changes yet.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #22388: WIP - Helm support local kubernetes executor
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on PR #22388:
URL: https://github.com/apache/airflow/pull/22388#issuecomment-1094063453
Hey @subkanthi, let's get this in the next release so we have day 1 support when 2.3.0 goes out. I think we have a test to fix, otherwise this is ready to go right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #22388: Helm support local kubernetes executor
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #22388:
URL: https://github.com/apache/airflow/pull/22388#discussion_r848536784
##########
tests/charts/test_basic_helm_chart.py:
##########
@@ -327,7 +327,8 @@ def test_unsupported_executor(self):
},
)
assert (
- 'executor must be one of the following: "LocalExecutor", "CeleryExecutor", '
+ 'executor must be one of the following: "LocalExecutor", '
Review Comment:
It's a little fragile, yeah, but honestly it changes so infrequently I think it's okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] subkanthi commented on pull request #22388: WIP - Helm support local kubernetes executor
Posted by GitBox <gi...@apache.org>.
subkanthi commented on PR #22388:
URL: https://github.com/apache/airflow/pull/22388#issuecomment-1094069466
> Hey @subkanthi, let's get this in the next release so we have day 1 support when 2.3.0 goes out. I think we have a test to fix, otherwise this is ready to go right?
Sure, will fix the test and pull the latest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] subkanthi commented on a diff in pull request #22388: Helm support local kubernetes executor
Posted by GitBox <gi...@apache.org>.
subkanthi commented on code in PR #22388:
URL: https://github.com/apache/airflow/pull/22388#discussion_r846832333
##########
tests/charts/test_basic_helm_chart.py:
##########
@@ -327,7 +327,8 @@ def test_unsupported_executor(self):
},
)
assert (
- 'executor must be one of the following: "LocalExecutor", "CeleryExecutor", '
+ 'executor must be one of the following: "LocalExecutor", '
Review Comment:
Assert on the error message maybe is not a good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #22388: WIP - Helm support local kubernetes executor
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #22388:
URL: https://github.com/apache/airflow/pull/22388#discussion_r846644944
##########
chart/values.yaml:
##########
@@ -219,7 +219,7 @@ rbac:
createSCCRoleBinding: false
# Airflow executor
-# Options: LocalExecutor, CeleryExecutor, KubernetesExecutor, CeleryKubernetesExecutor
+# Options: LocalExecutor, LocalKubernetesExecutor, CeleryExecutor, KubernetesExecutor, CeleryKubernetesExecutor
Review Comment:
```suggestion
# One of: LocalExecutor, LocalKubernetesExecutor, CeleryExecutor, KubernetesExecutor, CeleryKubernetesExecutor
```
Gets us 1 character down :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #22388: Helm support local kubernetes executor
Posted by GitBox <gi...@apache.org>.
jedcunningham merged PR #22388:
URL: https://github.com/apache/airflow/pull/22388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] subkanthi closed pull request #22388: Helm support local kubernetes executor
Posted by GitBox <gi...@apache.org>.
subkanthi closed pull request #22388: Helm support local kubernetes executor
URL: https://github.com/apache/airflow/pull/22388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22388: Helm support local kubernetes executor
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22388:
URL: https://github.com/apache/airflow/pull/22388#issuecomment-1096841596
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org