You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by attilapiros <gi...@git.apache.org> on 2018/05/02 09:00:11 UTC

[GitHub] spark pull request #21068: [SPARK-16630][YARN] Blacklist a node if executors...

Github user attilapiros commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21068#discussion_r185432837
  
    --- Diff: core/src/test/scala/org/apache/spark/HeartbeatReceiverSuite.scala ---
    @@ -73,6 +73,7 @@ class HeartbeatReceiverSuite
         sc = spy(new SparkContext(conf))
         scheduler = mock(classOf[TaskSchedulerImpl])
         when(sc.taskScheduler).thenReturn(scheduler)
    +    when(scheduler.nodeBlacklistWithExpiryTimes).thenReturn(Predef.Map[String, Long]())
    --- End diff --
    
    Yes, that was reason. I can remove the import of 'scala.collection.Map' and adapt  org.apache.spark.HeartbeatReceiverSuite#getTrackedExecutors which is the only one place where  collection.Map is need.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org