You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/09/09 11:29:27 UTC

[GitHub] [rocketmq] yuz10 commented on a change in pull request #3318: [ISSUE #2724] Resend message to DLQ directly when max reconsume times reach

yuz10 commented on a change in pull request #3318:
URL: https://github.com/apache/rocketmq/pull/3318#discussion_r705239632



##########
File path: store/src/main/java/org/apache/rocketmq/store/CommitLog.java
##########
@@ -582,7 +584,7 @@ private String generateKey(StringBuilder keyBuilder, MessageExt messageExt) {
         if (tranType == MessageSysFlag.TRANSACTION_NOT_TYPE
                 || tranType == MessageSysFlag.TRANSACTION_COMMIT_TYPE) {
             // Delay Delivery
-            if (msg.getDelayTimeLevel() > 0) {
+            if (msg.getDelayTimeLevel() > 0 && !isDLQTopic(msg.getTopic())) {

Review comment:
       We could remove the delay_level property of DLQ msg from the source




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org