You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "scala-steward (via GitHub)" <gi...@apache.org> on 2023/02/24 00:01:29 UTC
[GitHub] [daffodil] scala-steward opened a new pull request, #971: Update scalafmt-core to 3.7.2
scala-steward opened a new pull request, #971:
URL: https://github.com/apache/daffodil/pull/971
Updates [org.scalameta:scalafmt-core](https://github.com/scalameta/scalafmt) from 3.7.1 to 3.7.2.
[GitHub Release Notes](https://github.com/scalameta/scalafmt/releases/tag/v3.7.2) - [Version Diff](https://github.com/scalameta/scalafmt/compare/v3.7.1...v3.7.2)
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a [`.scala-steward.conf`](https://github.com/scala-steward-org/scala-steward/blob/5216d470ca33a3122bd4d49f084faddf160ee48e/docs/repo-specific-configuration.md) file.
Have a fantastic day writing Scala!
<details>
<summary>Files still referring to the old version number</summary>
The following files still refer to the old version number (3.7.1).
You might want to review and update them manually.
```
daffodil-lib/src/main/scala/org/apache/daffodil/lib/util/BitOrder.scala
```
</details>
<details>
<summary>Adjust future updates</summary>
Add this to your `.scala-steward.conf` file to ignore future updates of this dependency:
```
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]
```
Or, add this to slow down future updates of this dependency:
```
dependencyOverrides = [{
pullRequests = { frequency = "30 days" },
dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]
```
</details>
labels: library-update, early-semver-patch, semver-spec-patch, old-version-remains, commit-count:n:3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] tuxji commented on a diff in pull request #971: Update scalafmt-core to 3.7.2
Posted by "tuxji (via GitHub)" <gi...@apache.org>.
tuxji commented on code in PR #971:
URL: https://github.com/apache/daffodil/pull/971#discussion_r1117408436
##########
.git-blame-ignore-revs:
##########
@@ -0,0 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Scala Steward: Reformat with scalafmt 3.7.2
+3a80d550794d1278a636cd4d4a2ec0f33976f4a2
Review Comment:
> I think this commit hash will change once this PR is merged because of the rebase. I suggest we add the `.git-blame-ignore-revs` file after this one is merged, and add multiple commit hashes (e.g. OSGI refactor, the previous scalafmt commit) in a separate PR.
That makes sense, although I'm disappointed it won't be as straightforward to merge future PRs from Scala Steward bumping scalafmt to new versions as I thought (unless we merge its PR so quickly so that a rebase won't be needed, or Scala Steward understands "@scala-steward rebase"). FYI, I don't have time to update the PR branch today, so I'll let you do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] tuxji commented on pull request #971: Update scalafmt-core to 3.7.2
Posted by "tuxji (via GitHub)" <gi...@apache.org>.
tuxji commented on PR #971:
URL: https://github.com/apache/daffodil/pull/971#issuecomment-1442630913
Note that Scala Stewart formatted the refactoring scripts too. It's probably not worth explicitly excluding the scripts since reformatting them doesn't change their functionality anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on a diff in pull request #971: Update scalafmt-core to 3.7.2
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on code in PR #971:
URL: https://github.com/apache/daffodil/pull/971#discussion_r1116974242
##########
.git-blame-ignore-revs:
##########
@@ -0,0 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Scala Steward: Reformat with scalafmt 3.7.2
+3a80d550794d1278a636cd4d4a2ec0f33976f4a2
Review Comment:
I think this commit hash will change once this PR is merged because of the rebase. I suggest we add the `.git-blame-ignore-revs` file after this one is merged, and add multiple commit hashes (e.g. OSGI refactor, the previous scalafmt commit) in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on a diff in pull request #971: Update scalafmt-core to 3.7.2
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on code in PR #971:
URL: https://github.com/apache/daffodil/pull/971#discussion_r1117417502
##########
.git-blame-ignore-revs:
##########
@@ -0,0 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Scala Steward: Reformat with scalafmt 3.7.2
+3a80d550794d1278a636cd4d4a2ec0f33976f4a2
Review Comment:
Hopefully new scalafmt versions don't cause many, or any, changes. This one seems unique because I guess the old version missed the scripts?
Note that I think even if a rebase isn't needed, I *think* GitGub still changes something in the commit when we merge+rebase to cause the hash to change. I think maybe the committer author/date updated to when it's merged, which always updates the hash? So no matter how fast you merge, the hash will always change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence merged pull request #971: Update scalafmt-core to 3.7.2
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence merged PR #971:
URL: https://github.com/apache/daffodil/pull/971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org