You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by gauravaradhye <gi...@git.apache.org> on 2015/03/24 05:50:17 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8278: Usage test path - Correc...
GitHub user gauravaradhye opened a pull request:
https://github.com/apache/cloudstack/pull/127
CLOUDSTACK-8278: Usage test path - Correct code flow in case the usage job configuration is not to be set through test case
The flag "setUsageConfigurationThroughTestCase" dictates whether we should set the usage related config from test case itself (And restart the management server and usage server in the process) or not.
When the flag is False (When we don't want to disrupt other test cases and/or usage server/job is already configured), then it should be ensured that the code is not broken anywhere.
Currently the value of the flag is True, hence by default test case sets the usage global setting values and restarts the management and usage server in the process. This can disrupt other test case execution going on in parallel. So making the default value of the flag to False and also making changes in the test case to ensure test case works correctly in this case.
If we are running the test suite on a separate setup and want to set global settings related to usage through test case itself, then we can turn the flag to True whenever required before the run.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gauravaradhye/cloudstack 8278
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/127.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #127
----
commit 5ad31da1dc751e0a358f1657dee98c5bd3b1b7c6
Author: Gaurav Aradhye <ga...@clogeny.com>
Date: 2015-02-23T10:48:16Z
CLOUDSTACK-8278: Usage test path - Correct code flow in case the usage job configuration is not to be set through test case
commit 71653dc1388f431e9bb4e7758cc43a813902e12b
Author: Gaurav Aradhye <ga...@clogeny.com>
Date: 2015-03-24T04:46:01Z
Setting the default value of flag to False
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8278: Usage test path - Correc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/127
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8278: Usage test path - Correc...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/127#issuecomment-85456697
@gauravaradhye looks good, merging.. if this break travis you need to fix it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---