You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/27 03:26:34 UTC

[GitHub] [airflow] Junnplus commented on a change in pull request #13906: Make webserver rolling update

Junnplus commented on a change in pull request #13906:
URL: https://github.com/apache/airflow/pull/13906#discussion_r565000311



##########
File path: chart/templates/webserver/webserver-deployment.yaml
##########
@@ -39,7 +39,7 @@ spec:
   strategy:
     type: RollingUpdate
     rollingUpdate:
-      maxUnavailable: 1
+      maxUnavailable: 0

Review comment:
       > It's possible that users explicitly specify the replicas to 1, for some purposes. In that case, users take the responsibility and should be aware of the result.
   
   I don't think so, now replicas defaults to 1, upgrade chart always waiting long time, this will make the webserver unavailable.
   Of course, set replicas to >=2 can solve this problem, but everyone needs to do it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org