You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-commits@lucene.apache.org by ma...@apache.org on 2010/02/11 04:14:30 UTC
svn commit: r908818 -
/lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/SolrZkClient.java
Author: markrmiller
Date: Thu Feb 11 03:14:30 2010
New Revision: 908818
URL: http://svn.apache.org/viewvc?rev=908818&view=rev
Log:
remove nocommits
Modified:
lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/SolrZkClient.java
Modified: lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/SolrZkClient.java
URL: http://svn.apache.org/viewvc/lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/SolrZkClient.java?rev=908818&r1=908817&r2=908818&view=diff
==============================================================================
--- lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/SolrZkClient.java (original)
+++ lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/SolrZkClient.java Thu Feb 11 03:14:30 2010
@@ -40,8 +40,6 @@
*
* All Solr ZooKeeper interactions should go through this class rather than
* ZooKeeper. This class handles synchronous connects and reconnections.
- *
- * nocommit: and may end up optionally queuing commands when zk is down
*
*/
public class SolrZkClient {
@@ -356,7 +354,7 @@
// set new watch
exists(currentPath, watcher);
} else if (i == paths.length - 1) {
- // nocommit: version ?
+ // TODO: version ? for now, don't worry about race
setData(currentPath, data, -1);
// set new watch
exists(currentPath, watcher);
@@ -474,8 +472,6 @@
* @throws InterruptedException
*/
public void close() throws InterruptedException {
- // nocommit
- log.info("closing SolrZKClient " + this);
keeper.close();
}
@@ -485,13 +481,7 @@
* @param keeper
*/
void updateKeeper(SolrZooKeeper keeper) {
- // nocommit
- log.info("Updating ZooKeeper instance:" + keeper);
this.keeper = keeper;
}
- // for testing
- void dissconect() throws InterruptedException {
- this.keeper.close();
- }
}