You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@teaclave.apache.org by Gordon King <no...@github.com.INVALID> on 2021/09/28 21:37:31 UTC
[apache/incubator-teaclave] [docker] start Teaclave docker services
with auto-detection mechanism (#559)
## Description
Added a bash script to detect sgx device and aesm service
heuristically, and start teaclave services without needing to specify
corresponding docker compose file manually. this script can detect and
handle containerized aesm service as well.
Fixes #553
## Type of change (select or add applied and delete the others)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [X] API change with a documentation update
- [ ] Additional test coverage
- [ ] Code cleanup or just sync with upstream third-party crates
## How has this been tested?
## Checklist
- [X] Fork the repo and create your branch from `master`.
- [ ] If you've added code that should be tested, add tests.
- [X] If you've changed APIs, update the documentation.
- [ ] Ensure the tests pass (see CI results).
- [ ] Make sure your code lints/format.
You can view, comment on, or merge this pull request online at:
https://github.com/apache/incubator-teaclave/pull/559
-- Commit Summary --
* <a href="https://github.com/apache/incubator-teaclave/pull/559/commits/78fe8a24c2ad0bceb053c6324a6b8b2deb24b45d">[docker] start Teaclave docker services with auto-detection mechanism</a>
-- File Changes --
M docker/README.md (7)
A docker/docker-compose-aesm-socket.override.yml (61)
A docker/docker-compose-aesm-vol.override.yml (51)
A docker/docker-compose-dcap-dev.override.yml (54)
A docker/docker-compose-isgx-dev.override.yml (47)
D docker/docker-compose-ubuntu-1804-intel-sgx.yml (233)
D docker/docker-compose-ubuntu-1804-isgx.yml (226)
D docker/docker-compose-ubuntu-1804-sgx-sim-mode.yml (190)
M docker/docker-compose-ubuntu-1804.yml (35)
A docker/run-teaclave-services.sh (219)
-- Patch Links --
https://github.com/apache/incubator-teaclave/pull/559.patch
https://github.com/apache/incubator-teaclave/pull/559.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/559
Re: [apache/incubator-teaclave] [docker] start Teaclave docker
services with auto-detection mechanism (#559)
Posted by Mingshen Sun <no...@github.com.INVALID>.
I have fixed in PR #561. Please help to review and approve this PR (we won't merge any PR without review). Thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/559#issuecomment-933884816
Re: [apache/incubator-teaclave] [docker] start Teaclave docker
services with auto-detection mechanism (#559)
Posted by Gordon King <no...@github.com.INVALID>.
> I see several docs also contain instructions to use `docker-compose` to start services. Can you also change these? Thanks.
>
> * `docs/my-first-function.md`
> * `docs/azure-confidential-computing.md`
sure, will do. thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/559#issuecomment-931737029
Re: [apache/incubator-teaclave] [docker] start Teaclave docker
services with auto-detection mechanism (#559)
Posted by Mingshen Sun <no...@github.com.INVALID>.
> The CI identified the following issue.  Is it related to this PR? or anything I should fix in this PR? thanks.
This is caused by the CI environment. We didn't pin openssl to a specific version. We can resolve this issue in another PR.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/559#issuecomment-933756849
Re: [apache/incubator-teaclave] [docker] start Teaclave docker
services with auto-detection mechanism (#559)
Posted by Gordon King <no...@github.com.INVALID>.
The CI identified the following issue.
Is it related to this PR? anything I should fix in this PR? thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/559#issuecomment-933749841
Re: [apache/incubator-teaclave] [docker] start Teaclave docker
services with auto-detection mechanism (#559)
Posted by Mingshen Sun <no...@github.com.INVALID>.
Merged #559 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/559#event-5412730954
Re: [apache/incubator-teaclave] [docker] start Teaclave docker
services with auto-detection mechanism (#559)
Posted by Gordon King <no...@github.com.INVALID>.
> I have fixed in PR #561. Please help to review and approve this PR (we won't merge any PR without review). Thanks.
Will review and verify it, thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/559#issuecomment-934592617
Re: [apache/incubator-teaclave] [docker] start Teaclave docker
services with auto-detection mechanism (#559)
Posted by Mingshen Sun <no...@github.com.INVALID>.
I see several docs also contain instructions to use `docker-compose` to start services. Can you also change these? Thanks.
- `docs/my-first-function.md`
- `docs/azure-confidential-computing.md`
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/559#issuecomment-931633417
Re: [apache/incubator-teaclave] [docker] start Teaclave docker
services with auto-detection mechanism (#559)
Posted by Gordon King <no...@github.com.INVALID>.
My colleague helped me to identified an issue on his icelake server, I will add a fixup on top of this PR, thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/559#issuecomment-929725954
Re: [apache/incubator-teaclave] [docker] start Teaclave docker
services with auto-detection mechanism (#559)
Posted by Mingshen Sun <no...@github.com.INVALID>.
Thanks. This is really cool!
Let me test it on servers with different kinds of SGX drivers. (This also bother me since we cannot test this in our CI)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/559#issuecomment-929717820