You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Simon MacDonald <si...@gmail.com> on 2012/11/15 18:28:27 UTC
Changes to the JS?
Hey,
I'm noticing something weird today running mobile spec on Android. I'm get
File test failures and I think it is related to the Android WebView
implementations File, FileReader and FileError objects not being clobbered
like they should be.
Were their any changes around that area of the code?
Simon Mac Donald
http://hi.im/simonmacdonald
Re: Changes to the JS?
Posted by Brian LeRoux <b...@brian.io>.
+1
On Fri, Nov 16, 2012 at 6:49 AM, Andrew Grieve <ag...@chromium.org> wrote:
> Oh! This reminds me...
>
> When I was doing the navigator.connection work, I had a tough time figuring
> out how to get the builder to do the correct thing. It's a bit confusing
> because module.exports.objects in common.js don't clobber, but
> module.exports.objects in platform.js *do* clobber.
>
> I wanted to propose a change:
> for both common and platform:
> "merges" --> intoAndMerge
> "clobbers" --> intoAndClobber
> "defaults" --> intoButDoNotClobber
>
> get rid of "objects"
>
>
>
>
> On Thu, Nov 15, 2012 at 2:44 PM, Simon MacDonald
> <si...@gmail.com>wrote:
>
> > Nope, it was a change to the JS. The objects are no longer being
> clobbered
> > correctly. I know who to bug now.
> >
> > Thanks all.
> >
> > Simon Mac Donald
> > http://hi.im/simonmacdonald
> >
> >
> > On Thu, Nov 15, 2012 at 1:25 PM, Michal Mocny <mm...@chromium.org>
> wrote:
> >
> > > Just a wild guess:
> > >
> > > Way back when ios 6.0 beta came out, same thing happened due to
> > > webview adding a semi complete implementation, and we weren't forcing
> > > a clobber.
> > > Perhaps you updated to android 4.2 and perhaps its webview also added
> > > something and also needs a forced clobber..
> > >
> > > -Michal
> > >
> > > On Thu, Nov 15, 2012 at 12:28 PM, Simon MacDonald
> > > <si...@gmail.com> wrote:
> > > > Hey,
> > > >
> > > > I'm noticing something weird today running mobile spec on Android.
> I'm
> > > get
> > > > File test failures and I think it is related to the Android WebView
> > > > implementations File, FileReader and FileError objects not being
> > > clobbered
> > > > like they should be.
> > > >
> > > > Were their any changes around that area of the code?
> > > >
> > > > Simon Mac Donald
> > > > http://hi.im/simonmacdonald
> > >
> >
>
Re: Changes to the JS?
Posted by Gord Tanner <gt...@gmail.com>.
+1
On Thu, Nov 15, 2012 at 2:49 PM, Andrew Grieve <ag...@chromium.org> wrote:
> Oh! This reminds me...
>
> When I was doing the navigator.connection work, I had a tough time figuring
> out how to get the builder to do the correct thing. It's a bit confusing
> because module.exports.objects in common.js don't clobber, but
> module.exports.objects in platform.js *do* clobber.
>
> I wanted to propose a change:
> for both common and platform:
> "merges" --> intoAndMerge
> "clobbers" --> intoAndClobber
> "defaults" --> intoButDoNotClobber
>
> get rid of "objects"
>
>
>
>
> On Thu, Nov 15, 2012 at 2:44 PM, Simon MacDonald
> <si...@gmail.com>wrote:
>
> > Nope, it was a change to the JS. The objects are no longer being
> clobbered
> > correctly. I know who to bug now.
> >
> > Thanks all.
> >
> > Simon Mac Donald
> > http://hi.im/simonmacdonald
> >
> >
> > On Thu, Nov 15, 2012 at 1:25 PM, Michal Mocny <mm...@chromium.org>
> wrote:
> >
> > > Just a wild guess:
> > >
> > > Way back when ios 6.0 beta came out, same thing happened due to
> > > webview adding a semi complete implementation, and we weren't forcing
> > > a clobber.
> > > Perhaps you updated to android 4.2 and perhaps its webview also added
> > > something and also needs a forced clobber..
> > >
> > > -Michal
> > >
> > > On Thu, Nov 15, 2012 at 12:28 PM, Simon MacDonald
> > > <si...@gmail.com> wrote:
> > > > Hey,
> > > >
> > > > I'm noticing something weird today running mobile spec on Android.
> I'm
> > > get
> > > > File test failures and I think it is related to the Android WebView
> > > > implementations File, FileReader and FileError objects not being
> > > clobbered
> > > > like they should be.
> > > >
> > > > Were their any changes around that area of the code?
> > > >
> > > > Simon Mac Donald
> > > > http://hi.im/simonmacdonald
> > >
> >
>
Re: Changes to the JS?
Posted by Simon MacDonald <si...@gmail.com>.
We need to talk :)
Simon Mac Donald
http://hi.im/simonmacdonald
On Thu, Nov 15, 2012 at 2:49 PM, Andrew Grieve <ag...@chromium.org> wrote:
> Oh! This reminds me...
>
> When I was doing the navigator.connection work, I had a tough time figuring
> out how to get the builder to do the correct thing. It's a bit confusing
> because module.exports.objects in common.js don't clobber, but
> module.exports.objects in platform.js *do* clobber.
>
> I wanted to propose a change:
> for both common and platform:
> "merges" --> intoAndMerge
> "clobbers" --> intoAndClobber
> "defaults" --> intoButDoNotClobber
>
> get rid of "objects"
>
>
>
>
> On Thu, Nov 15, 2012 at 2:44 PM, Simon MacDonald
> <si...@gmail.com>wrote:
>
> > Nope, it was a change to the JS. The objects are no longer being
> clobbered
> > correctly. I know who to bug now.
> >
> > Thanks all.
> >
> > Simon Mac Donald
> > http://hi.im/simonmacdonald
> >
> >
> > On Thu, Nov 15, 2012 at 1:25 PM, Michal Mocny <mm...@chromium.org>
> wrote:
> >
> > > Just a wild guess:
> > >
> > > Way back when ios 6.0 beta came out, same thing happened due to
> > > webview adding a semi complete implementation, and we weren't forcing
> > > a clobber.
> > > Perhaps you updated to android 4.2 and perhaps its webview also added
> > > something and also needs a forced clobber..
> > >
> > > -Michal
> > >
> > > On Thu, Nov 15, 2012 at 12:28 PM, Simon MacDonald
> > > <si...@gmail.com> wrote:
> > > > Hey,
> > > >
> > > > I'm noticing something weird today running mobile spec on Android.
> I'm
> > > get
> > > > File test failures and I think it is related to the Android WebView
> > > > implementations File, FileReader and FileError objects not being
> > > clobbered
> > > > like they should be.
> > > >
> > > > Were their any changes around that area of the code?
> > > >
> > > > Simon Mac Donald
> > > > http://hi.im/simonmacdonald
> > >
> >
>
Re: Changes to the JS?
Posted by Andrew Grieve <ag...@chromium.org>.
Whoops, didn't notice that! Done!
On Thu, Nov 15, 2012 at 4:25 PM, Simon MacDonald
<si...@gmail.com>wrote:
> Yup, all File tests are passing for me too. In FileTransfer only one of
> the abort tests fails to run. BTW this thread is only me and you. You might
> want to post to the list letting them know everything is back to normal.
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>
>
> On Thu, Nov 15, 2012 at 4:20 PM, Andrew Grieve <ag...@chromium.org>wrote:
>
>> Okay, just pushed and have run spec tests before / after changes. They
>> File ones failed before and are fixed now.
>>
>> I'm seeing file transfer tests failing as well as contact ones. The
>> contact ones have always been flakey for me, but I'm not sure what's up
>> with FT. Maybe because I upgraded to 4.2? I'll have to look into it.
>>
>>
>> On Thu, Nov 15, 2012 at 3:34 PM, Andrew Grieve <ag...@chromium.org>wrote:
>>
>>> I didn't. I'm just about finished the rename from
>>> objects->defaults/clobbers and then will run the tests.
>>>
>>>
>>> On Thu, Nov 15, 2012 at 3:32 PM, Simon MacDonald <
>>> simon.macdonald@gmail.com> wrote:
>>>
>>>> Did you run it against mob-spec? It doesn't seem to change anything for
>>>> me. Could be me though.
>>>>
>>>> Simon Mac Donald
>>>> http://hi.im/simonmacdonald
>>>>
>>>>
>>>> On Thu, Nov 15, 2012 at 3:24 PM, Andrew Grieve <ag...@chromium.org>wrote:
>>>>
>>>>> Fix pushed.
>>>>>
>>>>>
>>>>> On Thu, Nov 15, 2012 at 3:23 PM, Simon MacDonald <
>>>>> simon.macdonald@gmail.com> wrote:
>>>>>
>>>>>> np
>>>>>>
>>>>>> Simon Mac Donald
>>>>>> http://hi.im/simonmacdonald
>>>>>>
>>>>>>
>>>>>> On Thu, Nov 15, 2012 at 3:22 PM, Andrew Grieve <ag...@chromium.org>wrote:
>>>>>>
>>>>>>> I'll fix the typo, and rename the keys. Thanks for finding this
>>>>>>> Simon.
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Nov 15, 2012 at 3:20 PM, Andrew Grieve <agrieve@chromium.org
>>>>>>> > wrote:
>>>>>>>
>>>>>>>> Oh snap. yeah, I see. Andrew broke it. Who can spot the typo?:
>>>>>>>>
>>>>>>>> if (platform.object) {
>>>>>>>>
>>>>>>>> builder.build(platform.objects).intoAndClobber(context);
>>>>>>>> }
>>>>>>>>
>>>>>>>>
>>>>>>>> On Thu, Nov 15, 2012 at 3:14 PM, Simon MacDonald <
>>>>>>>> simon.macdonald@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> Actually, I don't think the items in module.exports.objects in
>>>>>>>>> platform.js *do* clobber. At least what I'm seeing right now with the edge
>>>>>>>>> JS code File, FileReader and FileError are not clobbered.
>>>>>>>>>
>>>>>>>>> When I run the mobile spec file tests these test cases fail but if
>>>>>>>>> I revert back to 2.2.0 JS then all tests pass.
>>>>>>>>>
>>>>>>>>> Simon Mac Donald
>>>>>>>>> http://hi.im/simonmacdonald
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Thu, Nov 15, 2012 at 2:49 PM, Andrew Grieve <
>>>>>>>>> agrieve@chromium.org> wrote:
>>>>>>>>>
>>>>>>>>>> Oh! This reminds me...
>>>>>>>>>>
>>>>>>>>>> When I was doing the navigator.connection work, I had a tough
>>>>>>>>>> time figuring
>>>>>>>>>> out how to get the builder to do the correct thing. It's a bit
>>>>>>>>>> confusing
>>>>>>>>>> because module.exports.objects in common.js don't clobber, but
>>>>>>>>>> module.exports.objects in platform.js *do* clobber.
>>>>>>>>>>
>>>>>>>>>> I wanted to propose a change:
>>>>>>>>>> for both common and platform:
>>>>>>>>>> "merges" --> intoAndMerge
>>>>>>>>>> "clobbers" --> intoAndClobber
>>>>>>>>>> "defaults" --> intoButDoNotClobber
>>>>>>>>>>
>>>>>>>>>> get rid of "objects"
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Thu, Nov 15, 2012 at 2:44 PM, Simon MacDonald
>>>>>>>>>> <si...@gmail.com>wrote:
>>>>>>>>>>
>>>>>>>>>> > Nope, it was a change to the JS. The objects are no longer
>>>>>>>>>> being clobbered
>>>>>>>>>> > correctly. I know who to bug now.
>>>>>>>>>> >
>>>>>>>>>> > Thanks all.
>>>>>>>>>> >
>>>>>>>>>> > Simon Mac Donald
>>>>>>>>>> > http://hi.im/simonmacdonald
>>>>>>>>>> >
>>>>>>>>>> >
>>>>>>>>>> > On Thu, Nov 15, 2012 at 1:25 PM, Michal Mocny <
>>>>>>>>>> mmocny@chromium.org> wrote:
>>>>>>>>>> >
>>>>>>>>>> > > Just a wild guess:
>>>>>>>>>> > >
>>>>>>>>>> > > Way back when ios 6.0 beta came out, same thing happened due
>>>>>>>>>> to
>>>>>>>>>> > > webview adding a semi complete implementation, and we weren't
>>>>>>>>>> forcing
>>>>>>>>>> > > a clobber.
>>>>>>>>>> > > Perhaps you updated to android 4.2 and perhaps its webview
>>>>>>>>>> also added
>>>>>>>>>> > > something and also needs a forced clobber..
>>>>>>>>>> > >
>>>>>>>>>> > > -Michal
>>>>>>>>>> > >
>>>>>>>>>> > > On Thu, Nov 15, 2012 at 12:28 PM, Simon MacDonald
>>>>>>>>>> > > <si...@gmail.com> wrote:
>>>>>>>>>> > > > Hey,
>>>>>>>>>> > > >
>>>>>>>>>> > > > I'm noticing something weird today running mobile spec on
>>>>>>>>>> Android. I'm
>>>>>>>>>> > > get
>>>>>>>>>> > > > File test failures and I think it is related to the Android
>>>>>>>>>> WebView
>>>>>>>>>> > > > implementations File, FileReader and FileError objects not
>>>>>>>>>> being
>>>>>>>>>> > > clobbered
>>>>>>>>>> > > > like they should be.
>>>>>>>>>> > > >
>>>>>>>>>> > > > Were their any changes around that area of the code?
>>>>>>>>>> > > >
>>>>>>>>>> > > > Simon Mac Donald
>>>>>>>>>> > > > http://hi.im/simonmacdonald
>>>>>>>>>> > >
>>>>>>>>>> >
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
Re: Changes to the JS?
Posted by Andrew Grieve <ag...@chromium.org>.
Oh! This reminds me...
When I was doing the navigator.connection work, I had a tough time figuring
out how to get the builder to do the correct thing. It's a bit confusing
because module.exports.objects in common.js don't clobber, but
module.exports.objects in platform.js *do* clobber.
I wanted to propose a change:
for both common and platform:
"merges" --> intoAndMerge
"clobbers" --> intoAndClobber
"defaults" --> intoButDoNotClobber
get rid of "objects"
On Thu, Nov 15, 2012 at 2:44 PM, Simon MacDonald
<si...@gmail.com>wrote:
> Nope, it was a change to the JS. The objects are no longer being clobbered
> correctly. I know who to bug now.
>
> Thanks all.
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>
>
> On Thu, Nov 15, 2012 at 1:25 PM, Michal Mocny <mm...@chromium.org> wrote:
>
> > Just a wild guess:
> >
> > Way back when ios 6.0 beta came out, same thing happened due to
> > webview adding a semi complete implementation, and we weren't forcing
> > a clobber.
> > Perhaps you updated to android 4.2 and perhaps its webview also added
> > something and also needs a forced clobber..
> >
> > -Michal
> >
> > On Thu, Nov 15, 2012 at 12:28 PM, Simon MacDonald
> > <si...@gmail.com> wrote:
> > > Hey,
> > >
> > > I'm noticing something weird today running mobile spec on Android. I'm
> > get
> > > File test failures and I think it is related to the Android WebView
> > > implementations File, FileReader and FileError objects not being
> > clobbered
> > > like they should be.
> > >
> > > Were their any changes around that area of the code?
> > >
> > > Simon Mac Donald
> > > http://hi.im/simonmacdonald
> >
>
Re: Changes to the JS?
Posted by Simon MacDonald <si...@gmail.com>.
Nope, it was a change to the JS. The objects are no longer being clobbered
correctly. I know who to bug now.
Thanks all.
Simon Mac Donald
http://hi.im/simonmacdonald
On Thu, Nov 15, 2012 at 1:25 PM, Michal Mocny <mm...@chromium.org> wrote:
> Just a wild guess:
>
> Way back when ios 6.0 beta came out, same thing happened due to
> webview adding a semi complete implementation, and we weren't forcing
> a clobber.
> Perhaps you updated to android 4.2 and perhaps its webview also added
> something and also needs a forced clobber..
>
> -Michal
>
> On Thu, Nov 15, 2012 at 12:28 PM, Simon MacDonald
> <si...@gmail.com> wrote:
> > Hey,
> >
> > I'm noticing something weird today running mobile spec on Android. I'm
> get
> > File test failures and I think it is related to the Android WebView
> > implementations File, FileReader and FileError objects not being
> clobbered
> > like they should be.
> >
> > Were their any changes around that area of the code?
> >
> > Simon Mac Donald
> > http://hi.im/simonmacdonald
>
Re: Changes to the JS?
Posted by Michal Mocny <mm...@chromium.org>.
Just a wild guess:
Way back when ios 6.0 beta came out, same thing happened due to
webview adding a semi complete implementation, and we weren't forcing
a clobber.
Perhaps you updated to android 4.2 and perhaps its webview also added
something and also needs a forced clobber..
-Michal
On Thu, Nov 15, 2012 at 12:28 PM, Simon MacDonald
<si...@gmail.com> wrote:
> Hey,
>
> I'm noticing something weird today running mobile spec on Android. I'm get
> File test failures and I think it is related to the Android WebView
> implementations File, FileReader and FileError objects not being clobbered
> like they should be.
>
> Were their any changes around that area of the code?
>
> Simon Mac Donald
> http://hi.im/simonmacdonald