[jira] [Work logged] (HIVE-23746) Send task attempts async from AM to daemons

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-23746?focusedWorklogId=466880&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-466880 ]

ASF GitHub Bot logged work on HIVE-23746:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Aug/20 16:50
            Start Date: 05/Aug/20 16:50
    Worklog Time Spent: 10m 
      Work Description: pgaref commented on a change in pull request #1291:
URL: https://github.com/apache/hive/pull/1291#discussion_r465865701



##########
File path: llap-common/src/test/org/apache/hadoop/hive/llap/AsyncResponseHandlerTest.java
##########
@@ -0,0 +1,222 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.llap;
+
+import com.google.protobuf.Message;
+import org.apache.hadoop.hive.llap.AsyncPbRpcProxy.ExecuteRequestCallback;
+import org.apache.hadoop.util.concurrent.AsyncGet;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+
+import java.util.Random;
+import java.util.concurrent.TimeUnit;
+
+import static java.lang.Thread.sleep;
+import static org.mockito.Matchers.any;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+
+public class AsyncResponseHandlerTest {

Review comment:
       Class name should start with Test -> TestAsyncResponseHandler




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 466880)
    Time Spent: 40m  (was: 0.5h)

> Send task attempts async from AM to daemons
> -------------------------------------------
>
>                 Key: HIVE-23746
>                 URL: https://issues.apache.org/jira/browse/HIVE-23746
>             Project: Hive
>          Issue Type: Sub-task
>          Components: llap
>            Reporter: Mustafa Iman
>            Assignee: Mustafa Iman
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> LlapTaskCommunicator uses sync client to send task attempts. There are fixed number of communication threads (10 by default). This causes unneccessary delays when there are enough free execution slots in daemons but they do not receive all the tasks because of this bottleneck. LlapTaskCommunicator can use an async client to pass these tasks to daemons. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)