[GitHub] [flink] zhuzhurk commented on a change in pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph

[GitBox <gi...@apache.org>]

zhuzhurk commented on a change in pull request #14659:
URL: https://github.com/apache/flink/pull/14659#discussion_r559941714



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -938,7 +929,7 @@ public void suspend(Throwable suspensionCause) {
             initFailureCause(suspensionCause);
 
             // make sure no concurrent local actions interfere with the cancellation

Review comment:
       the comment is outdated

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -855,7 +846,7 @@ public void cancel() {
                 if (transitionState(current, JobStatus.CANCELLING)) {
 
                     // make sure no concurrent local actions interfere with the cancellation

Review comment:
       this comment is outdated.

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertex.java
##########
@@ -499,13 +497,12 @@ public void fail(Throwable t) {
         }
     }
 
-    public void resetForNewExecution(final long timestamp, final long expectedGlobalModVersion)
-            throws GlobalModVersionMismatch {
+    public void resetForNewExecution(final long timestamp) {

Review comment:
       it may be out of the scope of this task but I think this method is no longer needed in production code and can be removed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org