You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/04/06 12:01:44 UTC
[GitHub] [incubator-yunikorn-site] kingamarton opened a new pull request #42: [YUNIKORN-581] Updated application state machine
kingamarton opened a new pull request #42:
URL: https://github.com/apache/incubator-yunikorn-site/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] yangwwei commented on a change in pull request #42: [YUNIKORN-581] Updated application state machine
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #42:
URL: https://github.com/apache/incubator-yunikorn-site/pull/42#discussion_r608008833
##########
File path: docs/design/scheduler_object_states.md
##########
@@ -50,14 +50,15 @@ This state is part of the normal scheduling cycle.
* Running: The state in which the application will spend most of its time.
Containers/pods can be added to and removed from the application.
This state is part of the normal scheduling cycle.
-* Waiting: An application that has no pending requests or running containers/pod will be waiting.
+* Completing: An application that has no pending requests or running containers/pod will be completing.
This state shows that the application has not been marked completed yet but currently is not actively being scheduled.
-* Completed: An application is considered completed when it has been in the waiting state for a defined time period.
-From this state the application can only move to the Expired state and it cannot move back into any of scheduling states (Running or Waiting)
+* Completed: An application is considered completed when it has been in the completing state for a defined time period.
+From this state the application can only move to the Expired state, and it cannot move back into any of scheduling states (Running or Completing)
The current timeout is set to 30 seconds.
* Expired: The completed application is tracked for a period of time, after that is expired and deleted from the scheduler.
This is a final state and after this state the application cannot be tracked anymore.
-* Killed: Removed by the resource manager at the request of an administrator or the user running the application.
+* Failing: An application marked for failing, what still has some allocations or asks what needs to be cleaned up before entering into the Failed state.
Review comment:
can we add a bit more message about "when the app can be marked as Failing"?
Current context only explains what happens if the app is marked as Failing but not explained why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-site] yangwwei merged pull request #42: [YUNIKORN-581] Updated application state machine
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #42:
URL: https://github.com/apache/incubator-yunikorn-site/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org