You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by jp...@apache.org on 2018/02/26 16:39:31 UTC
mesos git commit: Fixed a typo in the NsTest.SupportedNamespaces test.
Repository: mesos
Updated Branches:
refs/heads/master 4f5a2500a -> 01b8504b7
Fixed a typo in the NsTest.SupportedNamespaces test.
This test tries to verify consistency across the APIs in the `ns`
namespace. We have a special case for user namespaces (that may be
available but not supported due to the kernel version), but we were
testing `CLONE_NEWNS` rather than `CLONE_NEWUSER`.
Review: https://reviews.apache.org/r/65804/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/01b8504b
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/01b8504b
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/01b8504b
Branch: refs/heads/master
Commit: 01b8504b78f7e708ec26c6160083bb3d6034d882
Parents: 4f5a250
Author: James Peach <jp...@apache.org>
Authored: Mon Feb 26 08:38:17 2018 -0800
Committer: James Peach <jp...@apache.org>
Committed: Mon Feb 26 08:38:17 2018 -0800
----------------------------------------------------------------------
src/tests/containerizer/ns_tests.cpp | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/01b8504b/src/tests/containerizer/ns_tests.cpp
----------------------------------------------------------------------
diff --git a/src/tests/containerizer/ns_tests.cpp b/src/tests/containerizer/ns_tests.cpp
index 904b933..fa4349e 100644
--- a/src/tests/containerizer/ns_tests.cpp
+++ b/src/tests/containerizer/ns_tests.cpp
@@ -99,9 +99,7 @@ TEST(NsTest, ROOT_setns)
// Test the ns::supported() API.
-//
-// TODO(alexr): Enable after MESOS-8610 is resolved.
-TEST(NsTest, DISABLED_SupportedNamespaces)
+TEST(NsTest, SupportedNamespaces)
{
set<int> namespaces = ns::nstypes();
ASSERT_FALSE(namespaces.empty());
@@ -114,7 +112,7 @@ TEST(NsTest, DISABLED_SupportedNamespaces)
foreach (const int& n, namespaces) {
// Exclude user namespaces because they depend on the kernel version.
- if (n == CLONE_NEWNS) {
+ if (n == CLONE_NEWUSER) {
continue;
}