You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/10/27 22:39:26 UTC
[GitHub] [helix] jiajunwang opened a new issue #1488: Participant side message handling logic may fail silently
jiajunwang opened a new issue #1488:
URL: https://github.com/apache/helix/issues/1488
### Describe the bug
There are more than one places in the participant code that the message processing may fail silently. Meaning no error state, no error message. The message is just discarded. When this kind of error happens, the controller or other components might keep sending the same messages repeatedly.
This may lead to a very serious result since controller / ZK resources may be exhausted.
### To Reproduce
Define a handler factory logic that will throw Exception on the create handler call.
The message will be removed but no ERROR state or other obvious failure can be observed from the controller side.
### Expected behavior
For state transition messages, we shall mark the corresponding partition to be ERROR.
For other messages, we shall leave the message that causes this error untouched.
### Additional context
Add any other context about the problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang closed issue #1488: Participant side message handling logic may fail silently
Posted by GitBox <gi...@apache.org>.
jiajunwang closed issue #1488:
URL: https://github.com/apache/helix/issues/1488
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org