You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/04/15 19:35:26 UTC

[GitHub] [incubator-mxnet] josephevans opened a new pull request #20177: Set required CI pipelines for protected branches.

josephevans opened a new pull request #20177:
URL: https://github.com/apache/incubator-mxnet/pull/20177


   ## Description ##
   This re-enables the required CI checks based on conversation in ASF-INFRA ticket: https://issues.apache.org/jira/browse/INFRA-21726.
   
   https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-BranchProtection


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] josephevans commented on pull request #20177: Set required CI pipelines for protected branches.

Posted by GitBox <gi...@apache.org>.
josephevans commented on pull request #20177:
URL: https://github.com/apache/incubator-mxnet/pull/20177#issuecomment-820703156


   @mxnet-bot run ci [all]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] josephevans closed pull request #20177: Set required CI pipelines for protected branches.

Posted by GitBox <gi...@apache.org>.
josephevans closed pull request #20177:
URL: https://github.com/apache/incubator-mxnet/pull/20177


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] josephevans commented on pull request #20177: Set required CI pipelines for protected branches.

Posted by GitBox <gi...@apache.org>.
josephevans commented on pull request #20177:
URL: https://github.com/apache/incubator-mxnet/pull/20177#issuecomment-820783499


   @szha From the documentation here: https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-BranchProtection
   
   ```
   NB (1): Enabling any of the above checks overrides what may have been set previously, so you'll need to add all the existing checks to your .asf.yaml to reproduce those previously set manually by Infra.
   
   NB (2): If you need to remove a required check in order to push a change to .asf.yaml, you will need to create an Infra Jira ticket with a request to have the check manually removed.
   ```
   
   and
   
   ```
   Branches that are not in the YAML or are not dictionary entries will not be protected.
   ```
   
   You are right, this will remove any other protected branches. I will update the ASF-INFRA ticket and ask them to manually re-enable them. I will close this PR (but am testing webhooks with Manu in the meantime, so may reopen and close this just for testing.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] josephevans closed pull request #20177: Set required CI pipelines for protected branches.

Posted by GitBox <gi...@apache.org>.
josephevans closed pull request #20177:
URL: https://github.com/apache/incubator-mxnet/pull/20177


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] josephevans closed pull request #20177: Set required CI pipelines for protected branches.

Posted by GitBox <gi...@apache.org>.
josephevans closed pull request #20177:
URL: https://github.com/apache/incubator-mxnet/pull/20177


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on pull request #20177: Set required CI pipelines for protected branches.

Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20177:
URL: https://github.com/apache/incubator-mxnet/pull/20177#issuecomment-820848623


   I think you can still enable required checks using pattern match of branch names. You can use `v*.x` to match all release branches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20177: Set required CI pipelines for protected branches.

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20177:
URL: https://github.com/apache/incubator-mxnet/pull/20177#issuecomment-820682283


   Hey @josephevans , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [centos-gpu, unix-gpu, website, sanity, unix-cpu, clang, windows-cpu, windows-gpu, centos-cpu, edge, miscellaneous]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] josephevans closed pull request #20177: Set required CI pipelines for protected branches.

Posted by GitBox <gi...@apache.org>.
josephevans closed pull request #20177:
URL: https://github.com/apache/incubator-mxnet/pull/20177


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] josephevans closed pull request #20177: Set required CI pipelines for protected branches.

Posted by GitBox <gi...@apache.org>.
josephevans closed pull request #20177:
URL: https://github.com/apache/incubator-mxnet/pull/20177


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] josephevans closed pull request #20177: Set required CI pipelines for protected branches.

Posted by GitBox <gi...@apache.org>.
josephevans closed pull request #20177:
URL: https://github.com/apache/incubator-mxnet/pull/20177


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] josephevans closed pull request #20177: Set required CI pipelines for protected branches.

Posted by GitBox <gi...@apache.org>.
josephevans closed pull request #20177:
URL: https://github.com/apache/incubator-mxnet/pull/20177


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org