[GitHub] [tvm] elvin-n commented on a change in pull request #8883: [Relay][Quantization] Per-Channel FQ2I

[GitBox <gi...@apache.org>]

elvin-n commented on a change in pull request #8883:
URL: https://github.com/apache/tvm/pull/8883#discussion_r699429138



##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -478,7 +478,7 @@ def _impl_v1(cls, inputs, attr, params):
                 attr["dilations"] = [1] + list(attr["dilations"])
             if "pads" in attr:
                 attr["pads"] = [0, attr["pads"][0], 0, attr["pads"][1]]
-
+        attr["channels"] = kernel_shapes[0][0]

Review comment:
       does this change relate to the subject of the PR or it is side fix? Don't see where "channels" attribute is used in other changes of this PR




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org