You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/09 07:29:59 UTC
[GitHub] [flink-table-store] openinx opened a new pull request, #115: [FLINK-27546] Add append only writer which implements the RecordWriter interface
openinx opened a new pull request, #115:
URL: https://github.com/apache/flink-table-store/pull/115
It's a sub PR for https://github.com/apache/flink-table-store/pull/99, which is trying to add an AppendOnlyWriter and unit test to accept records without any key or sort order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] openinx commented on a diff in pull request #115: [FLINK-27546] Add append only writer which implements the RecordWriter interface
Posted by GitBox <gi...@apache.org>.
openinx commented on code in PR #115:
URL: https://github.com/apache/flink-table-store/pull/115#discussion_r868723542
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/AppendOnlyWriter.java:
##########
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.table.store.file.writer;
+
+import org.apache.flink.api.common.serialization.BulkWriter;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.store.file.ValueKind;
+import org.apache.flink.table.store.file.data.DataFileMeta;
+import org.apache.flink.table.store.file.data.DataFilePathFactory;
+import org.apache.flink.table.store.file.format.FileFormat;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.store.file.stats.FieldStats;
+import org.apache.flink.table.store.file.stats.FieldStatsCollector;
+import org.apache.flink.table.store.file.stats.FileStatsExtractor;
+import org.apache.flink.table.store.file.utils.FileUtils;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.flink.shaded.guava30.com.google.common.collect.Lists;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Supplier;
+
+/**
+ * A {@link RecordWriter} implementation that only accepts records which are always insert
+ * operations and don't have any unique keys or sort keys.
+ */
+public class AppendOnlyWriter implements RecordWriter {
+ private final BulkWriter.Factory<RowData> writerFactory;
+ private final RowType writeSchema;
+ private final long targetFileSize;
+ private final DataFilePathFactory pathFactory;
+ private final FileStatsExtractor fileStatsExtractor;
+
+ private final AtomicLong nextSeqNum;
+
+ private RowRollingWriter writer;
+
+ public AppendOnlyWriter(
+ FileFormat fileFormat,
+ long targetFileSize,
+ RowType writeSchema,
+ long maxWroteSeqNumber,
+ DataFilePathFactory pathFactory) {
+
+ this.writerFactory = fileFormat.createWriterFactory(writeSchema);
+ this.writeSchema = writeSchema;
+ this.targetFileSize = targetFileSize;
+
+ this.pathFactory = pathFactory;
+ this.fileStatsExtractor = fileFormat.createStatsExtractor(writeSchema).orElse(null);
+
+ this.nextSeqNum = new AtomicLong(maxWroteSeqNumber + 1);
+
+ this.writer = createRollingRowWriter();
+ }
+
+ @Override
+ public void write(ValueKind valueKind, RowData key, RowData value) throws Exception {
+ Preconditions.checkArgument(
+ valueKind == ValueKind.ADD,
+ "Append-only writer cannot accept ValueKind: " + valueKind);
+
+ writer.write(value);
+ }
+
+ @Override
+ public Increment prepareCommit() throws Exception {
+ List<DataFileMeta> newFiles = Lists.newArrayList();
+
+ if (writer != null) {
+ writer.close();
+
+ // Reopen the writer to accept further records.
+ newFiles.addAll(writer.result());
+ writer = createRollingRowWriter();
+ }
+
+ return new Increment(Lists.newArrayList(newFiles));
+ }
+
+ @Override
+ public void sync() throws Exception {
+ // Do nothing here, as this writer don't introduce any async compaction thread currently.
+ }
+
+ @Override
+ public List<DataFileMeta> close() throws Exception {
+ sync();
+
+ List<DataFileMeta> result = Lists.newArrayList();
+ if (writer != null) {
+ // Abort this writer to clear uncommitted files.
+ writer.abort();
Review Comment:
Filed a separate issue for this: https://issues.apache.org/jira/browse/FLINK-27553
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/AppendOnlyWriter.java:
##########
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.table.store.file.writer;
+
+import org.apache.flink.api.common.serialization.BulkWriter;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.store.file.ValueKind;
+import org.apache.flink.table.store.file.data.DataFileMeta;
+import org.apache.flink.table.store.file.data.DataFilePathFactory;
+import org.apache.flink.table.store.file.format.FileFormat;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.store.file.stats.FieldStats;
+import org.apache.flink.table.store.file.stats.FieldStatsCollector;
+import org.apache.flink.table.store.file.stats.FileStatsExtractor;
+import org.apache.flink.table.store.file.utils.FileUtils;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.flink.shaded.guava30.com.google.common.collect.Lists;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Supplier;
+
+/**
+ * A {@link RecordWriter} implementation that only accepts records which are always insert
+ * operations and don't have any unique keys or sort keys.
+ */
+public class AppendOnlyWriter implements RecordWriter {
+ private final BulkWriter.Factory<RowData> writerFactory;
+ private final RowType writeSchema;
+ private final long targetFileSize;
+ private final DataFilePathFactory pathFactory;
+ private final FileStatsExtractor fileStatsExtractor;
+
+ private final AtomicLong nextSeqNum;
+
+ private RowRollingWriter writer;
+
+ public AppendOnlyWriter(
+ FileFormat fileFormat,
+ long targetFileSize,
+ RowType writeSchema,
+ long maxWroteSeqNumber,
+ DataFilePathFactory pathFactory) {
+
+ this.writerFactory = fileFormat.createWriterFactory(writeSchema);
+ this.writeSchema = writeSchema;
+ this.targetFileSize = targetFileSize;
+
+ this.pathFactory = pathFactory;
+ this.fileStatsExtractor = fileFormat.createStatsExtractor(writeSchema).orElse(null);
+
+ this.nextSeqNum = new AtomicLong(maxWroteSeqNumber + 1);
+
+ this.writer = createRollingRowWriter();
+ }
+
+ @Override
+ public void write(ValueKind valueKind, RowData key, RowData value) throws Exception {
+ Preconditions.checkArgument(
+ valueKind == ValueKind.ADD,
+ "Append-only writer cannot accept ValueKind: " + valueKind);
+
+ writer.write(value);
+ }
+
+ @Override
+ public Increment prepareCommit() throws Exception {
+ List<DataFileMeta> newFiles = Lists.newArrayList();
+
+ if (writer != null) {
+ writer.close();
+
+ // Reopen the writer to accept further records.
+ newFiles.addAll(writer.result());
+ writer = createRollingRowWriter();
+ }
+
+ return new Increment(Lists.newArrayList(newFiles));
+ }
+
+ @Override
+ public void sync() throws Exception {
+ // Do nothing here, as this writer don't introduce any async compaction thread currently.
+ }
+
+ @Override
+ public List<DataFileMeta> close() throws Exception {
+ sync();
+
+ List<DataFileMeta> result = Lists.newArrayList();
+ if (writer != null) {
+ // Abort this writer to clear uncommitted files.
+ writer.abort();
Review Comment:
Filed a separate issue for this: https://issues.apache.org/jira/browse/FLINK-27553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] openinx commented on a diff in pull request #115: [FLINK-27546] Add append only writer which implements the RecordWriter interface
Posted by GitBox <gi...@apache.org>.
openinx commented on code in PR #115:
URL: https://github.com/apache/flink-table-store/pull/115#discussion_r869077944
##########
flink-table-store-core/src/test/java/org/apache/flink/table/store/file/writer/TestAppendOnlyWriter.java:
##########
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.table.store.file.writer;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.table.data.GenericRowData;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.data.StringData;
+import org.apache.flink.table.data.binary.BinaryRowDataUtil;
+import org.apache.flink.table.store.file.ValueKind;
+import org.apache.flink.table.store.file.data.DataFileMeta;
+import org.apache.flink.table.store.file.data.DataFilePathFactory;
+import org.apache.flink.table.store.file.format.FileFormat;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.store.file.stats.FieldStats;
+import org.apache.flink.table.types.logical.IntType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.table.types.logical.VarCharType;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
+
+import java.util.Collections;
+import java.util.List;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+/** Test the correctness for {@link AppendOnlyWriter}. */
+public class TestAppendOnlyWriter {
Review Comment:
Thanks for the remaining, let me rename this class name.
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/AppendOnlyWriter.java:
##########
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.table.store.file.writer;
+
+import org.apache.flink.api.common.serialization.BulkWriter;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.store.file.ValueKind;
+import org.apache.flink.table.store.file.data.DataFileMeta;
+import org.apache.flink.table.store.file.data.DataFilePathFactory;
+import org.apache.flink.table.store.file.format.FileFormat;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.store.file.stats.FieldStats;
+import org.apache.flink.table.store.file.stats.FieldStatsCollector;
+import org.apache.flink.table.store.file.stats.FileStatsExtractor;
+import org.apache.flink.table.store.file.utils.FileUtils;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.flink.shaded.guava30.com.google.common.collect.Lists;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Supplier;
+
+/**
+ * A {@link RecordWriter} implementation that only accepts records which are always insert
+ * operations and don't have any unique keys or sort keys.
+ */
+public class AppendOnlyWriter implements RecordWriter {
+ private final BulkWriter.Factory<RowData> writerFactory;
+ private final RowType writeSchema;
+ private final long targetFileSize;
+ private final DataFilePathFactory pathFactory;
+ private final FileStatsExtractor fileStatsExtractor;
+ private final AtomicLong nextSeqNum;
+
+ private RowRollingWriter writer;
+
+ public AppendOnlyWriter(
+ FileFormat fileFormat,
+ long targetFileSize,
+ RowType writeSchema,
+ long maxWroteSeqNumber,
+ DataFilePathFactory pathFactory) {
+
+ this.writerFactory = fileFormat.createWriterFactory(writeSchema);
+ this.writeSchema = writeSchema;
+ this.targetFileSize = targetFileSize;
+ this.pathFactory = pathFactory;
+ this.fileStatsExtractor = fileFormat.createStatsExtractor(writeSchema).orElse(null);
+ this.nextSeqNum = new AtomicLong(maxWroteSeqNumber + 1);
+
+ this.writer = createRollingRowWriter();
+ }
+
+ @Override
+ public void write(ValueKind valueKind, RowData key, RowData value) throws Exception {
+ Preconditions.checkArgument(
+ valueKind == ValueKind.ADD,
+ "Append-only writer cannot accept ValueKind: " + valueKind);
+
+ writer.write(value);
+ }
+
+ @Override
+ public Increment prepareCommit() throws Exception {
+ List<DataFileMeta> newFiles = Lists.newArrayList();
+
+ if (writer != null) {
+ writer.close();
+ newFiles.addAll(writer.result());
+
+ // Reopen the writer to accept further records.
+ writer = createRollingRowWriter();
+ }
+
+ return new Increment(Lists.newArrayList(newFiles));
+ }
+
+ @Override
+ public void sync() throws Exception {
+ // Do nothing here, as this writer don't introduce any async compaction thread currently.
+ }
+
+ @Override
+ public List<DataFileMeta> close() throws Exception {
+ sync();
+
+ List<DataFileMeta> result = Lists.newArrayList();
Review Comment:
Okay, let's follow the coding rule.
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/AppendOnlyWriter.java:
##########
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.table.store.file.writer;
+
+import org.apache.flink.api.common.serialization.BulkWriter;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.store.file.ValueKind;
+import org.apache.flink.table.store.file.data.DataFileMeta;
+import org.apache.flink.table.store.file.data.DataFilePathFactory;
+import org.apache.flink.table.store.file.format.FileFormat;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.store.file.stats.FieldStats;
+import org.apache.flink.table.store.file.stats.FieldStatsCollector;
+import org.apache.flink.table.store.file.stats.FileStatsExtractor;
+import org.apache.flink.table.store.file.utils.FileUtils;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.flink.shaded.guava30.com.google.common.collect.Lists;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Supplier;
+
+/**
+ * A {@link RecordWriter} implementation that only accepts records which are always insert
+ * operations and don't have any unique keys or sort keys.
+ */
+public class AppendOnlyWriter implements RecordWriter {
+ private final BulkWriter.Factory<RowData> writerFactory;
+ private final RowType writeSchema;
+ private final long targetFileSize;
+ private final DataFilePathFactory pathFactory;
+ private final FileStatsExtractor fileStatsExtractor;
+ private final AtomicLong nextSeqNum;
+
+ private RowRollingWriter writer;
+
+ public AppendOnlyWriter(
+ FileFormat fileFormat,
+ long targetFileSize,
+ RowType writeSchema,
+ long maxWroteSeqNumber,
+ DataFilePathFactory pathFactory) {
+
+ this.writerFactory = fileFormat.createWriterFactory(writeSchema);
+ this.writeSchema = writeSchema;
+ this.targetFileSize = targetFileSize;
+ this.pathFactory = pathFactory;
+ this.fileStatsExtractor = fileFormat.createStatsExtractor(writeSchema).orElse(null);
+ this.nextSeqNum = new AtomicLong(maxWroteSeqNumber + 1);
+
+ this.writer = createRollingRowWriter();
+ }
+
+ @Override
+ public void write(ValueKind valueKind, RowData key, RowData value) throws Exception {
+ Preconditions.checkArgument(
+ valueKind == ValueKind.ADD,
+ "Append-only writer cannot accept ValueKind: " + valueKind);
+
+ writer.write(value);
+ }
+
+ @Override
+ public Increment prepareCommit() throws Exception {
+ List<DataFileMeta> newFiles = Lists.newArrayList();
+
+ if (writer != null) {
+ writer.close();
+ newFiles.addAll(writer.result());
+
+ // Reopen the writer to accept further records.
+ writer = createRollingRowWriter();
Review Comment:
Thanks for the careful reviewing. In fact, here we are creating the `RollingFileWriter` which will initializing the `DataFileWriter` lazily ( The `DataFileWriter` is the real writer that will try to open file descriptor to write records ).
Please check this lines: https://github.com/apache/flink-table-store/blob/master/flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/RollingFileWriter.java#L58-L69
So in theory, we won't add any extra empty `DataFileMeta` into the table format, even if we open an `AppendOnlyWriter` and call `prepareCommit` without writing any record.
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/data/DataFileMeta.java:
##########
@@ -49,6 +57,26 @@ public class DataFileMeta {
private final long maxSequenceNumber;
private final int level;
+ public DataFileMeta(
Review Comment:
Okay, that seems to be more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #115: [FLINK-27546] Add append only writer which implements the RecordWriter interface
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #115:
URL: https://github.com/apache/flink-table-store/pull/115#discussion_r868895004
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/AppendOnlyWriter.java:
##########
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.table.store.file.writer;
+
+import org.apache.flink.api.common.serialization.BulkWriter;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.store.file.ValueKind;
+import org.apache.flink.table.store.file.data.DataFileMeta;
+import org.apache.flink.table.store.file.data.DataFilePathFactory;
+import org.apache.flink.table.store.file.format.FileFormat;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.store.file.stats.FieldStats;
+import org.apache.flink.table.store.file.stats.FieldStatsCollector;
+import org.apache.flink.table.store.file.stats.FileStatsExtractor;
+import org.apache.flink.table.store.file.utils.FileUtils;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.flink.shaded.guava30.com.google.common.collect.Lists;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Supplier;
+
+/**
+ * A {@link RecordWriter} implementation that only accepts records which are always insert
+ * operations and don't have any unique keys or sort keys.
+ */
+public class AppendOnlyWriter implements RecordWriter {
+ private final BulkWriter.Factory<RowData> writerFactory;
+ private final RowType writeSchema;
+ private final long targetFileSize;
+ private final DataFilePathFactory pathFactory;
+ private final FileStatsExtractor fileStatsExtractor;
+ private final AtomicLong nextSeqNum;
+
+ private RowRollingWriter writer;
+
+ public AppendOnlyWriter(
+ FileFormat fileFormat,
+ long targetFileSize,
+ RowType writeSchema,
+ long maxWroteSeqNumber,
+ DataFilePathFactory pathFactory) {
+
+ this.writerFactory = fileFormat.createWriterFactory(writeSchema);
+ this.writeSchema = writeSchema;
+ this.targetFileSize = targetFileSize;
+ this.pathFactory = pathFactory;
+ this.fileStatsExtractor = fileFormat.createStatsExtractor(writeSchema).orElse(null);
+ this.nextSeqNum = new AtomicLong(maxWroteSeqNumber + 1);
+
+ this.writer = createRollingRowWriter();
+ }
+
+ @Override
+ public void write(ValueKind valueKind, RowData key, RowData value) throws Exception {
+ Preconditions.checkArgument(
+ valueKind == ValueKind.ADD,
+ "Append-only writer cannot accept ValueKind: " + valueKind);
+
+ writer.write(value);
+ }
+
+ @Override
+ public Increment prepareCommit() throws Exception {
+ List<DataFileMeta> newFiles = Lists.newArrayList();
+
+ if (writer != null) {
+ writer.close();
+ newFiles.addAll(writer.result());
+
+ // Reopen the writer to accept further records.
+ writer = createRollingRowWriter();
+ }
+
+ return new Increment(Lists.newArrayList(newFiles));
+ }
+
+ @Override
+ public void sync() throws Exception {
+ // Do nothing here, as this writer don't introduce any async compaction thread currently.
+ }
+
+ @Override
+ public List<DataFileMeta> close() throws Exception {
+ sync();
+
+ List<DataFileMeta> result = Lists.newArrayList();
Review Comment:
NIT: `new ArrayList<>();`
We don't use guava if we don't have to.
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/AppendOnlyWriter.java:
##########
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.table.store.file.writer;
+
+import org.apache.flink.api.common.serialization.BulkWriter;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.store.file.ValueKind;
+import org.apache.flink.table.store.file.data.DataFileMeta;
+import org.apache.flink.table.store.file.data.DataFilePathFactory;
+import org.apache.flink.table.store.file.format.FileFormat;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.store.file.stats.FieldStats;
+import org.apache.flink.table.store.file.stats.FieldStatsCollector;
+import org.apache.flink.table.store.file.stats.FileStatsExtractor;
+import org.apache.flink.table.store.file.utils.FileUtils;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.flink.shaded.guava30.com.google.common.collect.Lists;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Supplier;
+
+/**
+ * A {@link RecordWriter} implementation that only accepts records which are always insert
+ * operations and don't have any unique keys or sort keys.
+ */
+public class AppendOnlyWriter implements RecordWriter {
+ private final BulkWriter.Factory<RowData> writerFactory;
+ private final RowType writeSchema;
+ private final long targetFileSize;
+ private final DataFilePathFactory pathFactory;
+ private final FileStatsExtractor fileStatsExtractor;
+ private final AtomicLong nextSeqNum;
+
+ private RowRollingWriter writer;
+
+ public AppendOnlyWriter(
+ FileFormat fileFormat,
+ long targetFileSize,
+ RowType writeSchema,
+ long maxWroteSeqNumber,
+ DataFilePathFactory pathFactory) {
+
+ this.writerFactory = fileFormat.createWriterFactory(writeSchema);
+ this.writeSchema = writeSchema;
+ this.targetFileSize = targetFileSize;
+ this.pathFactory = pathFactory;
+ this.fileStatsExtractor = fileFormat.createStatsExtractor(writeSchema).orElse(null);
+ this.nextSeqNum = new AtomicLong(maxWroteSeqNumber + 1);
+
+ this.writer = createRollingRowWriter();
+ }
+
+ @Override
+ public void write(ValueKind valueKind, RowData key, RowData value) throws Exception {
+ Preconditions.checkArgument(
+ valueKind == ValueKind.ADD,
+ "Append-only writer cannot accept ValueKind: " + valueKind);
+
+ writer.write(value);
+ }
+
+ @Override
+ public Increment prepareCommit() throws Exception {
+ List<DataFileMeta> newFiles = Lists.newArrayList();
+
+ if (writer != null) {
+ writer.close();
+ newFiles.addAll(writer.result());
+
+ // Reopen the writer to accept further records.
+ writer = createRollingRowWriter();
+ }
+
+ return new Increment(Lists.newArrayList(newFiles));
+ }
+
+ @Override
+ public void sync() throws Exception {
+ // Do nothing here, as this writer don't introduce any async compaction thread currently.
+ }
+
+ @Override
+ public List<DataFileMeta> close() throws Exception {
+ sync();
+
+ List<DataFileMeta> result = Lists.newArrayList();
+ if (writer != null) {
+ // Abort this writer to clear uncommitted files.
+ writer.abort();
+
+ result.addAll(writer.result());
+ writer = null;
+ }
+
+ return result;
+ }
+
+ private RowRollingWriter createRollingRowWriter() {
+ return new RowRollingWriter(
+ () -> new RowFileWriter(writerFactory, pathFactory.newPath()), targetFileSize);
+ }
+
+ private class RowRollingWriter extends RollingFileWriter<RowData, DataFileMeta> {
+
+ public RowRollingWriter(Supplier<RowFileWriter> writerFactory, long targetFileSize) {
+ super(writerFactory, targetFileSize);
+ }
+ }
+
+ private class RowFileWriter extends BaseFileWriter<RowData, DataFileMeta> {
+ private final long startSeqNum;
Review Comment:
nit: `minSequenceNumber`?
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/AppendOnlyWriter.java:
##########
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.table.store.file.writer;
+
+import org.apache.flink.api.common.serialization.BulkWriter;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.store.file.ValueKind;
+import org.apache.flink.table.store.file.data.DataFileMeta;
+import org.apache.flink.table.store.file.data.DataFilePathFactory;
+import org.apache.flink.table.store.file.format.FileFormat;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.store.file.stats.FieldStats;
+import org.apache.flink.table.store.file.stats.FieldStatsCollector;
+import org.apache.flink.table.store.file.stats.FileStatsExtractor;
+import org.apache.flink.table.store.file.utils.FileUtils;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.flink.shaded.guava30.com.google.common.collect.Lists;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Supplier;
+
+/**
+ * A {@link RecordWriter} implementation that only accepts records which are always insert
+ * operations and don't have any unique keys or sort keys.
+ */
+public class AppendOnlyWriter implements RecordWriter {
+ private final BulkWriter.Factory<RowData> writerFactory;
+ private final RowType writeSchema;
+ private final long targetFileSize;
+ private final DataFilePathFactory pathFactory;
+ private final FileStatsExtractor fileStatsExtractor;
+ private final AtomicLong nextSeqNum;
+
+ private RowRollingWriter writer;
+
+ public AppendOnlyWriter(
+ FileFormat fileFormat,
+ long targetFileSize,
+ RowType writeSchema,
+ long maxWroteSeqNumber,
+ DataFilePathFactory pathFactory) {
+
+ this.writerFactory = fileFormat.createWriterFactory(writeSchema);
+ this.writeSchema = writeSchema;
+ this.targetFileSize = targetFileSize;
+ this.pathFactory = pathFactory;
+ this.fileStatsExtractor = fileFormat.createStatsExtractor(writeSchema).orElse(null);
+ this.nextSeqNum = new AtomicLong(maxWroteSeqNumber + 1);
+
+ this.writer = createRollingRowWriter();
+ }
+
+ @Override
+ public void write(ValueKind valueKind, RowData key, RowData value) throws Exception {
+ Preconditions.checkArgument(
+ valueKind == ValueKind.ADD,
+ "Append-only writer cannot accept ValueKind: " + valueKind);
+
+ writer.write(value);
+ }
+
+ @Override
+ public Increment prepareCommit() throws Exception {
+ List<DataFileMeta> newFiles = Lists.newArrayList();
+
+ if (writer != null) {
+ writer.close();
+ newFiles.addAll(writer.result());
+
+ // Reopen the writer to accept further records.
+ writer = createRollingRowWriter();
Review Comment:
Can we create this writer lazily? I can see always have a empty file in batch insert.
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/AppendOnlyWriter.java:
##########
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.table.store.file.writer;
+
+import org.apache.flink.api.common.serialization.BulkWriter;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.store.file.ValueKind;
+import org.apache.flink.table.store.file.data.DataFileMeta;
+import org.apache.flink.table.store.file.data.DataFilePathFactory;
+import org.apache.flink.table.store.file.format.FileFormat;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.store.file.stats.FieldStats;
+import org.apache.flink.table.store.file.stats.FieldStatsCollector;
+import org.apache.flink.table.store.file.stats.FileStatsExtractor;
+import org.apache.flink.table.store.file.utils.FileUtils;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.flink.shaded.guava30.com.google.common.collect.Lists;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Supplier;
+
+/**
+ * A {@link RecordWriter} implementation that only accepts records which are always insert
+ * operations and don't have any unique keys or sort keys.
+ */
+public class AppendOnlyWriter implements RecordWriter {
+ private final BulkWriter.Factory<RowData> writerFactory;
+ private final RowType writeSchema;
+ private final long targetFileSize;
+ private final DataFilePathFactory pathFactory;
+ private final FileStatsExtractor fileStatsExtractor;
+
+ private final AtomicLong nextSeqNum;
+
+ private RowRollingWriter writer;
+
+ public AppendOnlyWriter(
+ FileFormat fileFormat,
+ long targetFileSize,
+ RowType writeSchema,
+ long maxWroteSeqNumber,
+ DataFilePathFactory pathFactory) {
+
+ this.writerFactory = fileFormat.createWriterFactory(writeSchema);
+ this.writeSchema = writeSchema;
+ this.targetFileSize = targetFileSize;
+
+ this.pathFactory = pathFactory;
+ this.fileStatsExtractor = fileFormat.createStatsExtractor(writeSchema).orElse(null);
+
+ this.nextSeqNum = new AtomicLong(maxWroteSeqNumber + 1);
+
+ this.writer = createRollingRowWriter();
+ }
+
+ @Override
+ public void write(ValueKind valueKind, RowData key, RowData value) throws Exception {
+ Preconditions.checkArgument(
+ valueKind == ValueKind.ADD,
+ "Append-only writer cannot accept ValueKind: " + valueKind);
+
+ writer.write(value);
+ }
+
+ @Override
+ public Increment prepareCommit() throws Exception {
+ List<DataFileMeta> newFiles = Lists.newArrayList();
+
+ if (writer != null) {
+ writer.close();
+
+ // Reopen the writer to accept further records.
+ newFiles.addAll(writer.result());
+ writer = createRollingRowWriter();
+ }
+
+ return new Increment(Lists.newArrayList(newFiles));
+ }
+
+ @Override
+ public void sync() throws Exception {
+ // Do nothing here, as this writer don't introduce any async compaction thread currently.
+ }
+
+ @Override
+ public List<DataFileMeta> close() throws Exception {
+ sync();
+
+ List<DataFileMeta> result = Lists.newArrayList();
+ if (writer != null) {
+ // Abort this writer to clear uncommitted files.
+ writer.abort();
Review Comment:
Sounds good to me~
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/data/DataFileMeta.java:
##########
@@ -49,6 +57,26 @@ public class DataFileMeta {
private final long maxSequenceNumber;
private final int level;
+ public DataFileMeta(
Review Comment:
Can we have a static method , maybe just `DataFileMeta.fromAppend`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #115: [FLINK-27546] Add append only writer which implements the RecordWriter interface
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #115:
URL: https://github.com/apache/flink-table-store/pull/115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] openinx commented on a diff in pull request #115: [FLINK-27546] Add append only writer which implements the RecordWriter interface
Posted by GitBox <gi...@apache.org>.
openinx commented on code in PR #115:
URL: https://github.com/apache/flink-table-store/pull/115#discussion_r867721699
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/AppendOnlyWriter.java:
##########
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.table.store.file.writer;
+
+import org.apache.flink.api.common.serialization.BulkWriter;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.store.file.ValueKind;
+import org.apache.flink.table.store.file.data.DataFileMeta;
+import org.apache.flink.table.store.file.data.DataFilePathFactory;
+import org.apache.flink.table.store.file.format.FileFormat;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.store.file.stats.FieldStats;
+import org.apache.flink.table.store.file.stats.FieldStatsCollector;
+import org.apache.flink.table.store.file.stats.FileStatsExtractor;
+import org.apache.flink.table.store.file.utils.FileUtils;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.flink.shaded.guava30.com.google.common.collect.Lists;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Supplier;
+
+/**
+ * A {@link RecordWriter} implementation that only accepts records which are always insert
+ * operations and don't have any unique keys or sort keys.
+ */
+public class AppendOnlyWriter implements RecordWriter {
+ private final BulkWriter.Factory<RowData> writerFactory;
+ private final RowType writeSchema;
+ private final long targetFileSize;
+ private final DataFilePathFactory pathFactory;
+ private final FileStatsExtractor fileStatsExtractor;
+
+ private final AtomicLong nextSeqNum;
+
+ private RowRollingWriter writer;
+
+ public AppendOnlyWriter(
+ FileFormat fileFormat,
+ long targetFileSize,
+ RowType writeSchema,
+ long maxWroteSeqNumber,
+ DataFilePathFactory pathFactory) {
+
+ this.writerFactory = fileFormat.createWriterFactory(writeSchema);
+ this.writeSchema = writeSchema;
+ this.targetFileSize = targetFileSize;
+
+ this.pathFactory = pathFactory;
+ this.fileStatsExtractor = fileFormat.createStatsExtractor(writeSchema).orElse(null);
+
+ this.nextSeqNum = new AtomicLong(maxWroteSeqNumber + 1);
+
+ this.writer = createRollingRowWriter();
+ }
+
+ @Override
+ public void write(ValueKind valueKind, RowData key, RowData value) throws Exception {
+ Preconditions.checkArgument(
+ valueKind == ValueKind.ADD,
+ "Append-only writer cannot accept ValueKind: " + valueKind);
+
+ writer.write(value);
+ }
+
+ @Override
+ public Increment prepareCommit() throws Exception {
+ List<DataFileMeta> newFiles = Lists.newArrayList();
+
+ if (writer != null) {
+ writer.close();
+
+ // Reopen the writer to accept further records.
+ newFiles.addAll(writer.result());
+ writer = createRollingRowWriter();
+ }
+
+ return new Increment(Lists.newArrayList(newFiles));
+ }
+
+ @Override
+ public void sync() throws Exception {
+ // Do nothing here, as this writer don't introduce any async compaction thread currently.
+ }
+
+ @Override
+ public List<DataFileMeta> close() throws Exception {
+ sync();
+
+ List<DataFileMeta> result = Lists.newArrayList();
+ if (writer != null) {
+ // Abort this writer to clear uncommitted files.
+ writer.abort();
Review Comment:
I'm just curious that the `RecordWriter#close` will close the writer and **delete the uncommitted files** automatically, which is a bit mismatching the normal `close` semantic of writer. [1]
Actually, the behavior is more matching the `abort` semantic. So I filed a separate issue to address this issue. I mean we can define separate `abort()` and `close()` methods in this interface, and the `close()` will just close the opening writer, and the `abort()` will clean the uncommitted files. I think its semantic is more clear.
[1] https://github.com/apache/flink-table-store/blob/1fedb6586ba292bedf00bb1b6922d5110a2f7fa8/flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/RecordWriter.java#L51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] openinx closed pull request #115: [FLINK-27546] Add append only writer which implements the RecordWriter interface
Posted by GitBox <gi...@apache.org>.
openinx closed pull request #115: [FLINK-27546] Add append only writer which implements the RecordWriter interface
URL: https://github.com/apache/flink-table-store/pull/115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #115: [FLINK-27546] Add append only writer which implements the RecordWriter interface
Posted by GitBox <gi...@apache.org>.
tsreaper commented on code in PR #115:
URL: https://github.com/apache/flink-table-store/pull/115#discussion_r869830332
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/AppendOnlyWriter.java:
##########
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.table.store.file.writer;
+
+import org.apache.flink.api.common.serialization.BulkWriter;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.store.file.ValueKind;
+import org.apache.flink.table.store.file.data.DataFileMeta;
+import org.apache.flink.table.store.file.data.DataFilePathFactory;
+import org.apache.flink.table.store.file.format.FileFormat;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.store.file.stats.FieldStats;
+import org.apache.flink.table.store.file.stats.FieldStatsCollector;
+import org.apache.flink.table.store.file.stats.FileStatsExtractor;
+import org.apache.flink.table.store.file.utils.FileUtils;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Supplier;
+
+/**
+ * A {@link RecordWriter} implementation that only accepts records which are always insert
+ * operations and don't have any unique keys or sort keys.
+ */
+public class AppendOnlyWriter implements RecordWriter {
+ private final BulkWriter.Factory<RowData> writerFactory;
+ private final RowType writeSchema;
+ private final long targetFileSize;
+ private final DataFilePathFactory pathFactory;
+ private final FileStatsExtractor fileStatsExtractor;
+ private final AtomicLong nextSeqNum;
Review Comment:
[Previous discussion](https://github.com/apache/flink-table-store/pull/99#discussion_r868746358)
Inner class does not need final members. A primitive `long` is enough. Try it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #115: [FLINK-27546] Add append only writer which implements the RecordWriter interface
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #115:
URL: https://github.com/apache/flink-table-store/pull/115#discussion_r868889682
##########
flink-table-store-core/src/test/java/org/apache/flink/table/store/file/writer/TestAppendOnlyWriter.java:
##########
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.table.store.file.writer;
+
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.table.data.GenericRowData;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.data.StringData;
+import org.apache.flink.table.data.binary.BinaryRowDataUtil;
+import org.apache.flink.table.store.file.ValueKind;
+import org.apache.flink.table.store.file.data.DataFileMeta;
+import org.apache.flink.table.store.file.data.DataFilePathFactory;
+import org.apache.flink.table.store.file.format.FileFormat;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.store.file.stats.FieldStats;
+import org.apache.flink.table.types.logical.IntType;
+import org.apache.flink.table.types.logical.LogicalType;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.table.types.logical.VarCharType;
+
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
+
+import java.util.Collections;
+import java.util.List;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+/** Test the correctness for {@link AppendOnlyWriter}. */
+public class TestAppendOnlyWriter {
Review Comment:
Flink style is `AppendOnlyWriterTest`.
Only the classes `XXXTest` and `XXXITCase` will be run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] openinx commented on a diff in pull request #115: [FLINK-27546] Add append only writer which implements the RecordWriter interface
Posted by GitBox <gi...@apache.org>.
openinx commented on code in PR #115:
URL: https://github.com/apache/flink-table-store/pull/115#discussion_r869863607
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/AppendOnlyWriter.java:
##########
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.table.store.file.writer;
+
+import org.apache.flink.api.common.serialization.BulkWriter;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.store.file.ValueKind;
+import org.apache.flink.table.store.file.data.DataFileMeta;
+import org.apache.flink.table.store.file.data.DataFilePathFactory;
+import org.apache.flink.table.store.file.format.FileFormat;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.store.file.stats.FieldStats;
+import org.apache.flink.table.store.file.stats.FieldStatsCollector;
+import org.apache.flink.table.store.file.stats.FileStatsExtractor;
+import org.apache.flink.table.store.file.utils.FileUtils;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Supplier;
+
+/**
+ * A {@link RecordWriter} implementation that only accepts records which are always insert
+ * operations and don't have any unique keys or sort keys.
+ */
+public class AppendOnlyWriter implements RecordWriter {
+ private final BulkWriter.Factory<RowData> writerFactory;
+ private final RowType writeSchema;
+ private final long targetFileSize;
+ private final DataFilePathFactory pathFactory;
+ private final FileStatsExtractor fileStatsExtractor;
+ private final AtomicLong nextSeqNum;
Review Comment:
Yes, you are right. Lambda implementation needs final modifier, while inner class don't. https://stackoverflow.com/questions/34865383/variable-used-in-lambda-expression-should-be-final-or-effectively-final
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] openinx commented on pull request #115: [FLINK-27546] Add append only writer which implements the RecordWriter interface
Posted by GitBox <gi...@apache.org>.
openinx commented on PR #115:
URL: https://github.com/apache/flink-table-store/pull/115#issuecomment-1122323866
The failure e2e case is:
```
Error: testWithoutPk Time elapsed: 88.458 s <<< ERROR!
org.testcontainers.containers.ContainerLaunchException: Container startup failed
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:336)
at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:317)
at org.testcontainers.containers.ContainerisedDockerCompose.invoke(DockerComposeContainer.java:646)
at org.testcontainers.containers.DockerComposeContainer.runWithCompose(DockerComposeContainer.java:309)
at org.testcontainers.containers.DockerComposeContainer.createServices(DockerComposeContainer.java:233)
at org.testcontainers.containers.DockerComposeContainer.start(DockerComposeContainer.java:177)
at org.apache.flink.table.store.tests.E2eTestBase.before(E2eTestBase.java:102)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725)
at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
at org.junit.jupiter.engine.extension.TimeoutExtension.interceptLifecycleMethod(TimeoutExtension.java:126)
at org.junit.jupiter.engine.extension.TimeoutExtension.interceptBeforeEachMethod(TimeoutExtension.java:76)
at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.invokeMethodInExtensionContext(ClassBasedTestDescriptor.java:506)
at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$synthesizeBeforeEachMethodAdapter$21(ClassBasedTestDescriptor.java:491)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeEachMethods$3(TestMethodTestDescriptor.java:171)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeBeforeMethodsOrCallbacksUntilExceptionOccurs$6(TestMethodTestDescriptor.java:199)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeBeforeMethodsOrCallbacksUntilExceptionOccurs(TestMethodTestDescriptor.java:199)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeBeforeEachMethods(TestMethodTestDescriptor.java:168)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:131)
at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:66)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
at java.util.ArrayList.forEach(ArrayList.java:1259)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:35)
at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:54)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:220)
at org.junit.platform.launcher.core.DefaultLauncher.lambda$execute$6(DefaultLauncher.java:188)
at org.junit.platform.launcher.core.DefaultLauncher.withInterceptedStreams(DefaultLauncher.java:202)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:181)
at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:128)
at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:142)
at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:109)
at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:[329](https://github.com/apache/flink-table-store/runs/6368915717?check_suite_focus=true#step:5:329))
... 75 more
Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:525)
at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:[331](https://github.com/apache/flink-table-store/runs/6368915717?check_suite_focus=true#step:5:331))
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
... 76 more
Caused by: java.lang.IllegalStateException: Container did not start correctly.
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:463)
... 78 more
```
Let's just reopen to rerun the unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] openinx commented on a diff in pull request #115: [FLINK-27546] Add append only writer which implements the RecordWriter interface
Posted by GitBox <gi...@apache.org>.
openinx commented on code in PR #115:
URL: https://github.com/apache/flink-table-store/pull/115#discussion_r869802293
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/AppendOnlyWriter.java:
##########
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.table.store.file.writer;
+
+import org.apache.flink.api.common.serialization.BulkWriter;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.store.file.ValueKind;
+import org.apache.flink.table.store.file.data.DataFileMeta;
+import org.apache.flink.table.store.file.data.DataFilePathFactory;
+import org.apache.flink.table.store.file.format.FileFormat;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.store.file.stats.FieldStats;
+import org.apache.flink.table.store.file.stats.FieldStatsCollector;
+import org.apache.flink.table.store.file.stats.FileStatsExtractor;
+import org.apache.flink.table.store.file.utils.FileUtils;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.flink.shaded.guava30.com.google.common.collect.Lists;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Supplier;
+
+/**
+ * A {@link RecordWriter} implementation that only accepts records which are always insert
+ * operations and don't have any unique keys or sort keys.
+ */
+public class AppendOnlyWriter implements RecordWriter {
+ private final BulkWriter.Factory<RowData> writerFactory;
+ private final RowType writeSchema;
+ private final long targetFileSize;
+ private final DataFilePathFactory pathFactory;
+ private final FileStatsExtractor fileStatsExtractor;
+ private final AtomicLong nextSeqNum;
+
+ private RowRollingWriter writer;
+
+ public AppendOnlyWriter(
+ FileFormat fileFormat,
+ long targetFileSize,
+ RowType writeSchema,
+ long maxWroteSeqNumber,
+ DataFilePathFactory pathFactory) {
+
+ this.writerFactory = fileFormat.createWriterFactory(writeSchema);
+ this.writeSchema = writeSchema;
+ this.targetFileSize = targetFileSize;
+ this.pathFactory = pathFactory;
+ this.fileStatsExtractor = fileFormat.createStatsExtractor(writeSchema).orElse(null);
+ this.nextSeqNum = new AtomicLong(maxWroteSeqNumber + 1);
+
+ this.writer = createRollingRowWriter();
+ }
+
+ @Override
+ public void write(ValueKind valueKind, RowData key, RowData value) throws Exception {
+ Preconditions.checkArgument(
+ valueKind == ValueKind.ADD,
+ "Append-only writer cannot accept ValueKind: " + valueKind);
+
+ writer.write(value);
+ }
+
+ @Override
+ public Increment prepareCommit() throws Exception {
+ List<DataFileMeta> newFiles = Lists.newArrayList();
+
+ if (writer != null) {
+ writer.close();
+ newFiles.addAll(writer.result());
+
+ // Reopen the writer to accept further records.
+ writer = createRollingRowWriter();
Review Comment:
Added an unit test for this: https://github.com/apache/flink-table-store/pull/115/files#diff-d75bc35d7bf343c2eb454f30bc548fa52f4268d6f2147d30537b2332b5176c9aR68-R80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #115: [FLINK-27546] Add append only writer which implements the RecordWriter interface
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on code in PR #115:
URL: https://github.com/apache/flink-table-store/pull/115#discussion_r869956416
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/data/DataFileMeta.java:
##########
@@ -49,6 +57,46 @@ public class DataFileMeta {
private final long maxSequenceNumber;
private final int level;
+ public static DataFileMeta forAppend(
+ String fileName,
+ long fileSize,
+ long rowCount,
+ FieldStats[] rowStats,
+ long minSequenceNumber,
+ long maxSequenceNumber) {
+ return new DataFileMeta(
+ fileName,
+ fileSize,
+ rowCount,
+ EMPTY_MIN_KEY,
+ EMPTY_MAX_KEY,
+ EMPTY_KEY_STATS,
+ rowStats,
+ minSequenceNumber,
+ maxSequenceNumber,
+ DUMMY_LEVEL);
+ }
+
+ public DataFileMeta(
Review Comment:
Remove this method?
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/mergetree/Increment.java:
##########
@@ -35,12 +35,19 @@
*/
public class Increment {
+ private static final List<DataFileMeta> EMPTY_COMPACT_BEFORE = Collections.emptyList();
+ private static final List<DataFileMeta> EMPTY_COMPACT_AFTER = Collections.emptyList();
+
private final List<DataFileMeta> newFiles;
private final List<DataFileMeta> compactBefore;
private final List<DataFileMeta> compactAfter;
+ public Increment(List<DataFileMeta> newFiles) {
Review Comment:
Ditto: introduce a `forAppend`
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/AppendOnlyWriter.java:
##########
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.table.store.file.writer;
+
+import org.apache.flink.api.common.serialization.BulkWriter;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.store.file.ValueKind;
+import org.apache.flink.table.store.file.data.DataFileMeta;
+import org.apache.flink.table.store.file.data.DataFilePathFactory;
+import org.apache.flink.table.store.file.format.FileFormat;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.store.file.stats.FieldStats;
+import org.apache.flink.table.store.file.stats.FieldStatsCollector;
+import org.apache.flink.table.store.file.stats.FileStatsExtractor;
+import org.apache.flink.table.store.file.utils.FileUtils;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.function.Supplier;
+
+/**
+ * A {@link RecordWriter} implementation that only accepts records which are always insert
+ * operations and don't have any unique keys or sort keys.
+ */
+public class AppendOnlyWriter implements RecordWriter {
+ private final BulkWriter.Factory<RowData> writerFactory;
+ private final RowType writeSchema;
+ private final long targetFileSize;
+ private final DataFilePathFactory pathFactory;
+ private final FileStatsExtractor fileStatsExtractor;
+ private long nextSeqNum;
+
+ private RowRollingWriter writer;
+
+ public AppendOnlyWriter(
+ FileFormat fileFormat,
+ long targetFileSize,
+ RowType writeSchema,
+ long maxWroteSeqNumber,
+ DataFilePathFactory pathFactory) {
+
+ this.writerFactory = fileFormat.createWriterFactory(writeSchema);
+ this.writeSchema = writeSchema;
+ this.targetFileSize = targetFileSize;
+ this.pathFactory = pathFactory;
+ this.fileStatsExtractor = fileFormat.createStatsExtractor(writeSchema).orElse(null);
+ this.nextSeqNum = maxWroteSeqNumber + 1;
+
+ this.writer = createRollingRowWriter();
+ }
+
+ @Override
+ public void write(ValueKind valueKind, RowData key, RowData value) throws Exception {
+ Preconditions.checkArgument(
+ valueKind == ValueKind.ADD,
+ "Append-only writer cannot accept ValueKind: " + valueKind);
Review Comment:
We should avoid string concat here. Use
```
checkArgument(
boolean condition,
@Nullable String errorMessageTemplate,
@Nullable Object... errorMessageArgs
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] openinx commented on a diff in pull request #115: [FLINK-27546] Add append only writer which implements the RecordWriter interface
Posted by GitBox <gi...@apache.org>.
openinx commented on code in PR #115:
URL: https://github.com/apache/flink-table-store/pull/115#discussion_r868723547
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/writer/AppendOnlyWriter.java:
##########
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.flink.table.store.file.writer;
+
+import org.apache.flink.api.common.serialization.BulkWriter;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.store.file.ValueKind;
+import org.apache.flink.table.store.file.data.DataFileMeta;
+import org.apache.flink.table.store.file.data.DataFilePathFactory;
+import org.apache.flink.table.store.file.format.FileFormat;
+import org.apache.flink.table.store.file.mergetree.Increment;
+import org.apache.flink.table.store.file.stats.FieldStats;
+import org.apache.flink.table.store.file.stats.FieldStatsCollector;
+import org.apache.flink.table.store.file.stats.FileStatsExtractor;
+import org.apache.flink.table.store.file.utils.FileUtils;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.flink.util.Preconditions;
+
+import org.apache.flink.shaded.guava30.com.google.common.collect.Lists;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.function.Supplier;
+
+/**
+ * A {@link RecordWriter} implementation that only accepts records which are always insert
+ * operations and don't have any unique keys or sort keys.
+ */
+public class AppendOnlyWriter implements RecordWriter {
+ private final BulkWriter.Factory<RowData> writerFactory;
+ private final RowType writeSchema;
+ private final long targetFileSize;
+ private final DataFilePathFactory pathFactory;
+ private final FileStatsExtractor fileStatsExtractor;
+
+ private final AtomicLong nextSeqNum;
+
+ private RowRollingWriter writer;
+
+ public AppendOnlyWriter(
+ FileFormat fileFormat,
+ long targetFileSize,
+ RowType writeSchema,
+ long maxWroteSeqNumber,
+ DataFilePathFactory pathFactory) {
+
+ this.writerFactory = fileFormat.createWriterFactory(writeSchema);
+ this.writeSchema = writeSchema;
+ this.targetFileSize = targetFileSize;
+
+ this.pathFactory = pathFactory;
+ this.fileStatsExtractor = fileFormat.createStatsExtractor(writeSchema).orElse(null);
+
+ this.nextSeqNum = new AtomicLong(maxWroteSeqNumber + 1);
+
+ this.writer = createRollingRowWriter();
+ }
+
+ @Override
+ public void write(ValueKind valueKind, RowData key, RowData value) throws Exception {
+ Preconditions.checkArgument(
+ valueKind == ValueKind.ADD,
+ "Append-only writer cannot accept ValueKind: " + valueKind);
+
+ writer.write(value);
+ }
+
+ @Override
+ public Increment prepareCommit() throws Exception {
+ List<DataFileMeta> newFiles = Lists.newArrayList();
+
+ if (writer != null) {
+ writer.close();
+
+ // Reopen the writer to accept further records.
+ newFiles.addAll(writer.result());
+ writer = createRollingRowWriter();
+ }
+
+ return new Increment(Lists.newArrayList(newFiles));
+ }
+
+ @Override
+ public void sync() throws Exception {
+ // Do nothing here, as this writer don't introduce any async compaction thread currently.
+ }
+
+ @Override
+ public List<DataFileMeta> close() throws Exception {
+ sync();
+
+ List<DataFileMeta> result = Lists.newArrayList();
+ if (writer != null) {
+ // Abort this writer to clear uncommitted files.
+ writer.abort();
Review Comment:
Filed a separate issue for this: https://issues.apache.org/jira/browse/FLINK-27553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org