You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/13 09:27:41 UTC

[GitHub] [spark] Yikun opened a new pull request #35189: [SPARK-37879][INFRA][FOLLOWUP] Change actions to check-runs in update_build_status.yml

Yikun opened a new pull request #35189:
URL: https://github.com/apache/spark/pull/35189


   ### What changes were proposed in this pull request?
   Change actions to check-runs in update_build_status.yml.
   
   
   ### Why are the changes needed?
   https://github.com/apache/spark/pull/35179#issuecomment-1011881076
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Yikun edited a comment on pull request #35189: [SPARK-37879][INFRA][FOLLOWUP] Change actions to check-runs in update_build_status.yml

Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #35189:
URL: https://github.com/apache/spark/pull/35189#issuecomment-1012013450


   Yep, below is the right way for update_build_status:
   1. First get the check_suite id data.check_suite.id:
   https://api.github.com/repos/Yikun/spark/check-runs/4797718278
   2. Then we need a extra api request on check-suites, get the status of check-suites as final status
   https://api.github.com/repos/Yikun/spark/check-suites/4918519335
   
   See also:
   https://github.com/apache/spark/pull/35192/files


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Yikun edited a comment on pull request #35189: [SPARK-37879][INFRA][FOLLOWUP] Change actions to check-runs in update_build_status.yml

Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #35189:
URL: https://github.com/apache/spark/pull/35189#issuecomment-1012013450


   Yep, below is the right way for update_build_status:
   1. First get the check_suite id data.check_suite.id:
   https://api.github.com/repos/Yikun/spark/check-runs/4797718278
   2. Then we need a extra api request on check-suites, get the status of check-suites as final status
   https://api.github.com/repos/Yikun/spark/check-suites/4918519335
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #35189: [SPARK-37879][INFRA][FOLLOWUP] Change actions to check-runs in update_build_status.yml

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35189:
URL: https://github.com/apache/spark/pull/35189#issuecomment-1011952711






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #35189: [SPARK-37879][INFRA][FOLLOWUP] Change actions to check-runs in update_build_status.yml

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35189:
URL: https://github.com/apache/spark/pull/35189#issuecomment-1011991632


   Ah, this only checks the status of "Configure Jobs" .. am gonna revert this and original PR for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Yikun commented on pull request #35189: [SPARK-37879][INFRA][FOLLOWUP] Change actions to check-runs in update_build_status.yml

Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #35189:
URL: https://github.com/apache/spark/pull/35189#issuecomment-1012013450


   Yep, below is the right way for update_build_status:
   1. First get the check_suite id:
   https://api.github.com/repos/Yikun/spark/check-runs/4797718278
   2. Then we need a extra api request on check-suites, get the status of check-suites as final status
   https://api.github.com/repos/Yikun/spark/check-suites/4918519335
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #35189: [SPARK-37879][INFRA][FOLLOWUP] Change actions to check-runs in update_build_status.yml

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #35189:
URL: https://github.com/apache/spark/pull/35189


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org