You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/04 02:33:53 UTC
[GitHub] [pulsar] baomingyu opened a new pull request #12615: fix 12614, waitingForPingResponse needs to be modified with volatile for concurrent sence
baomingyu opened a new pull request #12615:
URL: https://github.com/apache/pulsar/pull/12615
Fixes #12614
Master Issue: #12614
waitingForPingResponse was used in PulsarHandler for check if or not close connection.
and it was set value in different thread , so it must to be modified with volatile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #12615: fix 12614, waitingForPingResponse needs to be modified with volatile for concurrent sence
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12615:
URL: https://github.com/apache/pulsar/pull/12615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #12615: fix 12614, waitingForPingResponse needs to be modified with volatile for concurrent sence
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #12615:
URL: https://github.com/apache/pulsar/pull/12615#issuecomment-960725635
@baomingyu Oh sorry, I see it, one is the IO thread, another one is the executor of the `ChannelHandlerContext`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #12615: fix 12614, waitingForPingResponse needs to be modified with volatile for concurrent sence
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12615:
URL: https://github.com/apache/pulsar/pull/12615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #12615: fix 12614, waitingForPingResponse needs to be modified with volatile for concurrent sence
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12615:
URL: https://github.com/apache/pulsar/pull/12615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #12615: fix 12614, waitingForPingResponse needs to be modified with volatile for concurrent sence
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12615:
URL: https://github.com/apache/pulsar/pull/12615#issuecomment-960389988
@baomingyu:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aloyszhang commented on pull request #12615: fix 12614, waitingForPingResponse needs to be modified with volatile for concurrent sence
Posted by GitBox <gi...@apache.org>.
aloyszhang commented on pull request #12615:
URL: https://github.com/apache/pulsar/pull/12615#issuecomment-960660141
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org