You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by Emmanuel Lecharny <el...@gmail.com> on 2010/09/29 01:56:57 UTC

[3.0.0] Acceptors/connectors

  Hi,

yesterday I reviewed the Service interface and the associated hierarchy. 
basically, we have either Acceptors or Connectors.

 From those two interfaces, we derive :
(Acceptors) : NioDatagramAcceptor, AprSocketAcceptor, NioSocketAcceptor, 
VmPipeSocketAcceptor
(Connectors) : NioDatagramConnector, AprSocketConnector, 
NioSocketConnector, VmPipeSocketConnector plus some extra connectors, 
SerialConnector and ProxyConnector

I don't know why the VmPipeSocketConnector has 'socket' in it, because 
AFAIU, it has nothing to do with Socket. I don't know what the 
ProxyConnector is good for, but I must admit I didn't checked the code. 
Anyone has a clue?

Otherwise, I think we should also add a IoSocketConnector and 
IoSocketAcceptor, to cover the whole IO spectrum (if it's possible).

thoughts ?

-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com


Re : [3.0.0] Acceptors/connectors

Posted by Edouard De Oliveira <do...@yahoo.fr>.
Yup ashish it's exactly that althought i had terrible time with some other parts 
of the implementation which would be nice to improve in 3.0 (but it was a long 
time ago so i just have vague memories of it right now)
 Cordialement, Regards,
-Edouard De Oliveira-
WebSite: http://tedorg.free.fr/en/main.php



----- Message d'origine ----
De : Ashish <pa...@gmail.com>
À : dev@mina.apache.org; elecharny@apache.org
Envoyé le : Mer 29 septembre 2010, 14h 45min 11s
Objet : Re: [3.0.0] Acceptors/connectors

On Wed, Sep 29, 2010 at 10:38 AM, Ashish <pa...@gmail.com> wrote:
> On Wed, Sep 29, 2010 at 5:26 AM, Emmanuel Lecharny <el...@gmail.com> 
wrote:
>>  Hi,
>>
>> yesterday I reviewed the Service interface and the associated hierarchy.
>> basically, we have either Acceptors or Connectors.
>>
>> From those two interfaces, we derive :
>> (Acceptors) : NioDatagramAcceptor, AprSocketAcceptor, NioSocketAcceptor,
>> VmPipeSocketAcceptor
>> (Connectors) : NioDatagramConnector, AprSocketConnector, NioSocketConnector,
>> VmPipeSocketConnector plus some extra connectors, SerialConnector and
>> ProxyConnector
>>
>> I don't know why the VmPipeSocketConnector has 'socket' in it, because
>> AFAIU, it has nothing to do with Socket. I don't know what the
>> ProxyConnector is good for, but I must admit I didn't checked the code.
>> Anyone has a clue?
>
> IMHO, just to have uniformity.
> I can look into ProxyConnector and find something.

Could not find VmPipeSocketConnector class, the code does have
VmPipeConnector :(

Had a quick look at ProxyConnector. It intercepts your connect
requests, and instead of connecting to intended destination,
connects to a Proxy. Its a nice way to implement a Proxy over various
transports :)

I liked it.



      


Re: [3.0.0] Acceptors/connectors

Posted by Ashish <pa...@gmail.com>.
On Wed, Sep 29, 2010 at 10:38 AM, Ashish <pa...@gmail.com> wrote:
> On Wed, Sep 29, 2010 at 5:26 AM, Emmanuel Lecharny <el...@gmail.com> wrote:
>>  Hi,
>>
>> yesterday I reviewed the Service interface and the associated hierarchy.
>> basically, we have either Acceptors or Connectors.
>>
>> From those two interfaces, we derive :
>> (Acceptors) : NioDatagramAcceptor, AprSocketAcceptor, NioSocketAcceptor,
>> VmPipeSocketAcceptor
>> (Connectors) : NioDatagramConnector, AprSocketConnector, NioSocketConnector,
>> VmPipeSocketConnector plus some extra connectors, SerialConnector and
>> ProxyConnector
>>
>> I don't know why the VmPipeSocketConnector has 'socket' in it, because
>> AFAIU, it has nothing to do with Socket. I don't know what the
>> ProxyConnector is good for, but I must admit I didn't checked the code.
>> Anyone has a clue?
>
> IMHO, just to have uniformity.
> I can look into ProxyConnector and find something.

Could not find VmPipeSocketConnector class, the code does have
VmPipeConnector :(

Had a quick look at ProxyConnector. It intercepts your connect
requests, and instead of connecting to intended destination,
connects to a Proxy. Its a nice way to implement a Proxy over various
transports :)

I liked it.

Re: [3.0.0] Acceptors/connectors

Posted by Ashish <pa...@gmail.com>.
On Wed, Sep 29, 2010 at 5:26 AM, Emmanuel Lecharny <el...@gmail.com> wrote:
>  Hi,
>
> yesterday I reviewed the Service interface and the associated hierarchy.
> basically, we have either Acceptors or Connectors.
>
> From those two interfaces, we derive :
> (Acceptors) : NioDatagramAcceptor, AprSocketAcceptor, NioSocketAcceptor,
> VmPipeSocketAcceptor
> (Connectors) : NioDatagramConnector, AprSocketConnector, NioSocketConnector,
> VmPipeSocketConnector plus some extra connectors, SerialConnector and
> ProxyConnector
>
> I don't know why the VmPipeSocketConnector has 'socket' in it, because
> AFAIU, it has nothing to do with Socket. I don't know what the
> ProxyConnector is good for, but I must admit I didn't checked the code.
> Anyone has a clue?

IMHO, just to have uniformity.
I can look into ProxyConnector and find something.

>
> Otherwise, I think we should also add a IoSocketConnector and
> IoSocketAcceptor, to cover the whole IO spectrum (if it's possible).
>
> thoughts ?

I feel, we should start simple, by supporting Socket stuff first,
build the framework and then on adding Serial, BIO, etc.
Not to sacrifice generic nature of framework off-course :)
Probably its easier said than done.

+1 for adding IoSocketConnector/Acceptor

-- 
thanks
ashish