Re: Let's fix the Rat Check usability fail

[Dennis Lundberg <de...@apache.org>]

Hi,

Sorry for being late to the discussion. Here are my thoughts on the subject.

I agree that we should turn on Rat by default for all our projects
within Apache Maven. There are still a bunch of projects that
currently fail the Rat check, see private area in svn for more info.
Some of them fail because Rat 0.10 doesn't correctly identify certain
file types. Others fail because they have files without license
headers. These need to either add license headers or add exclusions to
the project's configuration.

I've been tweaking Rat to cover everything we need when it comes to
file type detection and 0.11-SNAPSHOT is working fine for me. Let me
try to push for a release of Rat so that we can take advantage of the
improvements in the newer version.


On Sun, May 18, 2014 at 7:04 PM, Jason van Zyl <ja...@takari.io> wrote:
> Right now though we require all files to have license headers we do not run the check to verify this by default.
>
> It kept dinging me until I turned it on by default in Maven core. Someone currently trying to contribute has no idea this is a requirement and is not told so because it doesn't run by default. If it's required how about we just run all the time everywhere?
>
> I would like to change the POMs so that it always runs. Having to run RAT separately is a usability fail. The chances of anyone contributing knowing they have to run it are pretty close to zero.
>
> Anyone see a reason not to always run it?
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder,  Apache Maven
> http://twitter.com/jvanzyl
> http://twitter.com/takari_io
> ---------------------------------------------------------
>
> We all have problems. How we deal with them is a measure of our worth.
>
>  -- Unknown
>
>
>
>
>
>
>
>
>



-- 
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org