You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mahout.apache.org by "Dan Filimon (JIRA)" <ji...@apache.org> on 2013/01/02 12:58:12 UTC

[jira] [Commented] (MAHOUT-1135) Unify decorated vectors in DecoratedVector

    [ https://issues.apache.org/jira/browse/MAHOUT-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13542095#comment-13542095 ] 

Dan Filimon commented on MAHOUT-1135:
-------------------------------------

On a related note, all these vectors should implement Cloneable so DecoratedVector<T> should probably be abstract (it just can't implement Cloneable because T cannot be instantiated and you can't construct a new T object using reflection).
The different subclasses could override clone() and be concrete. 
                
> Unify decorated vectors in DecoratedVector<T>
> ---------------------------------------------
>
>                 Key: MAHOUT-1135
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1135
>             Project: Mahout
>          Issue Type: Wish
>          Components: Math
>    Affects Versions: 1.0
>            Reporter: Dan Filimon
>            Priority: Minor
>              Labels: improvement, vector
>
> I'm finding the current Vector classes in Mahout a bit confusing.
> The vector implementation are just fine, I'm talking more about the decorated vectors:
> WeightedVector
> MatrixSlice
> NamedVector
> I propose using a single DecoratedVector<T> type that can easily be extended.
> For example, right now MatrixSlice doesn't even implement the Vector interface.
> So,
> WeightedVector -> DecoratedVector<Pair<Integer, Double>>
> MatrixSlice -> DecoratedVector<Integer>
> NamedVector -> DecoratedVector<String>
> We could even keep the names (maybe changing MatrixSlice to something like IndexedVector though?) by extending DecoratedVector<T>.
> I'd be willing to fix this if people think it's a good idea.
> What about it? :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira