You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/01/27 14:34:42 UTC

[GitHub] [skywalking-nodejs] tom-pytel commented on pull request #28: added http.method to plugins

tom-pytel commented on pull request #28:
URL: https://github.com/apache/skywalking-nodejs/pull/28#issuecomment-768326440


   Ok, I really do not understand, I changed the fields affected by the PR in the expected.data.yaml files and it still fails. Comparing the "actualData" from the failure against the expected data it all matches up except for some "isError: false" which are not present in expected.data.yaml, but that yaml without the "isError" is coming from the previous successful master which I assume is ok. So for future pushes so that I can get the test right can you please show me what I am missing in order to get the test to succeed?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org