You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2014/07/17 03:05:49 UTC
Review Request 23595: Add the gradle shadow plugin (for fat jar support)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23595/
-----------------------------------------------------------
Review request for Aurora, Bill Farner and Brian Wickman.
Repository: aurora
Description
-------
Add the gradle shadow plugin (for fat jar support)
Diffs
-----
build.gradle 751bde2f5052c66eac043f0b784c6e3bef9d3de3
Diff: https://reviews.apache.org/r/23595/diff/
Testing
-------
Built a fat jar, verified that it contains all transitive aurora dependencies and runs.
% ./gradlew shadowJar
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf8
:bootstrapThrift UP-TO-DATE
:checkPython
:generateSources UP-TO-DATE
:compileGeneratedJava UP-TO-DATE
:processGeneratedResources UP-TO-DATE
:generatedClasses UP-TO-DATE
:compileJava UP-TO-DATE
:processResources UP-TO-DATE
:classes UP-TO-DATE
:shadowJar
BUILD SUCCESSFUL
Total time: 20.956 secs
% jar tf dist/libs/aurora-0.5.0-SNAPSHOT-all.jar | wc -l
Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf8
20712
% java -jar dist/libs/aurora-0.5.0-SNAPSHOT-all.jar -help 2>/dev/null | wc -l
235
Thanks,
Kevin Sweeney
Re: Review Request 23595: Add the gradle shadow plugin (for fat jar support)
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23595/#review48027
-----------------------------------------------------------
Thanks for the gut check, discarding this review.
- Kevin Sweeney
On July 16, 2014, 6:05 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23595/
> -----------------------------------------------------------
>
> (Updated July 16, 2014, 6:05 p.m.)
>
>
> Review request for Aurora, Bill Farner and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add the gradle shadow plugin (for fat jar support)
>
>
> Diffs
> -----
>
> build.gradle 751bde2f5052c66eac043f0b784c6e3bef9d3de3
>
> Diff: https://reviews.apache.org/r/23595/diff/
>
>
> Testing
> -------
>
> Built a fat jar, verified that it contains all transitive aurora dependencies and runs.
>
> % ./gradlew shadowJar
> Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf8
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources UP-TO-DATE
> :compileGeneratedJava UP-TO-DATE
> :processGeneratedResources UP-TO-DATE
> :generatedClasses UP-TO-DATE
> :compileJava UP-TO-DATE
> :processResources UP-TO-DATE
> :classes UP-TO-DATE
> :shadowJar
>
> BUILD SUCCESSFUL
>
> Total time: 20.956 secs
> % jar tf dist/libs/aurora-0.5.0-SNAPSHOT-all.jar | wc -l
> Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf8
> 20712
> % java -jar dist/libs/aurora-0.5.0-SNAPSHOT-all.jar -help 2>/dev/null | wc -l
> 235
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 23595: Add the gradle shadow plugin (for fat jar support)
Posted by Jake Farrell <jf...@apache.org>.
> On July 17, 2014, 5:33 p.m., Bill Farner wrote:
> > 'Fat jars' are inherently problematic. Some libraries expect resources at well-known locations, which would be candidate for brittleness when there are collisions. Jar signing is also broken by this approach. Unless there's a compelling reason to introduce this trouble, i suggest we stay far, far away.
+1, agree with avoiding this
- Jake
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23595/#review48022
-----------------------------------------------------------
On July 17, 2014, 1:05 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23595/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 1:05 a.m.)
>
>
> Review request for Aurora, Bill Farner and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add the gradle shadow plugin (for fat jar support)
>
>
> Diffs
> -----
>
> build.gradle 751bde2f5052c66eac043f0b784c6e3bef9d3de3
>
> Diff: https://reviews.apache.org/r/23595/diff/
>
>
> Testing
> -------
>
> Built a fat jar, verified that it contains all transitive aurora dependencies and runs.
>
> % ./gradlew shadowJar
> Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf8
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources UP-TO-DATE
> :compileGeneratedJava UP-TO-DATE
> :processGeneratedResources UP-TO-DATE
> :generatedClasses UP-TO-DATE
> :compileJava UP-TO-DATE
> :processResources UP-TO-DATE
> :classes UP-TO-DATE
> :shadowJar
>
> BUILD SUCCESSFUL
>
> Total time: 20.956 secs
> % jar tf dist/libs/aurora-0.5.0-SNAPSHOT-all.jar | wc -l
> Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf8
> 20712
> % java -jar dist/libs/aurora-0.5.0-SNAPSHOT-all.jar -help 2>/dev/null | wc -l
> 235
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 23595: Add the gradle shadow plugin (for fat jar support)
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23595/#review48022
-----------------------------------------------------------
'Fat jars' are inherently problematic. Some libraries expect resources at well-known locations, which would be candidate for brittleness when there are collisions. Jar signing is also broken by this approach. Unless there's a compelling reason to introduce this trouble, i suggest we stay far, far away.
- Bill Farner
On July 17, 2014, 1:05 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23595/
> -----------------------------------------------------------
>
> (Updated July 17, 2014, 1:05 a.m.)
>
>
> Review request for Aurora, Bill Farner and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Add the gradle shadow plugin (for fat jar support)
>
>
> Diffs
> -----
>
> build.gradle 751bde2f5052c66eac043f0b784c6e3bef9d3de3
>
> Diff: https://reviews.apache.org/r/23595/diff/
>
>
> Testing
> -------
>
> Built a fat jar, verified that it contains all transitive aurora dependencies and runs.
>
> % ./gradlew shadowJar
> Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf8
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources UP-TO-DATE
> :compileGeneratedJava UP-TO-DATE
> :processGeneratedResources UP-TO-DATE
> :generatedClasses UP-TO-DATE
> :compileJava UP-TO-DATE
> :processResources UP-TO-DATE
> :classes UP-TO-DATE
> :shadowJar
>
> BUILD SUCCESSFUL
>
> Total time: 20.956 secs
> % jar tf dist/libs/aurora-0.5.0-SNAPSHOT-all.jar | wc -l
> Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=utf8
> 20712
> % java -jar dist/libs/aurora-0.5.0-SNAPSHOT-all.jar -help 2>/dev/null | wc -l
> 235
>
>
> Thanks,
>
> Kevin Sweeney
>
>