You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Rall <dl...@collab.net> on 2003/03/10 20:11:32 UTC
[PATCH] MIME types, peer review
Message-ID <3E...@therealm.demon.co.uk> contains a patch as
an attachment.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] MIME types, peer review
Posted by Daniel Rall <dl...@finemaltcoding.com>.
Karl Fogel <kf...@newton.ch.collab.net> writes:
...
> Most people who do code review read every message, or at least see
> every thread, and decide to review based mainly on time and interest,
> anyway (I think).
This is not the case in other projects I'm involved in, but like I
said, YMMV.
--
Daniel Rall <dl...@finemaltcoding.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] MIME types, peer review
Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Daniel Rall <dl...@finemaltcoding.com> writes:
> > Hummm. He explicitly explained why he did not mark with [PATCH]. If
> > you have reason to think marking it as patch nonetheless is the right
> > thing to do, you failed to explain those reasons.
>
> IMHO, it's more likely to get review if marked with PATCH...YMMV.
The main function of "[PATCH]" is to signal the patch manager and
others that this is something that needs to be tracked, because it
might want to go into Subversion. So if the submitter explicitly
chose not to do that, we shouldn't second guess.
Most people who do code review read every message, or at least see
every thread, and decide to review based mainly on time and interest,
anyway (I think).
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] MIME types, peer review
Posted by Daniel Rall <dl...@finemaltcoding.com>.
Benjamin Pflugmann <be...@pflugmann.de> writes:
> On Mon 2003-03-10 at 12:11:32 -0800, Daniel Rall wrote:
> > Message-ID <3E...@therealm.demon.co.uk> contains a patch as
> > an attachment.
>
> Hummm. He explicitly explained why he did not mark with [PATCH]. If
> you have reason to think marking it as patch nonetheless is the right
> thing to do, you failed to explain those reasons.
IMHO, it's more likely to get review if marked with PATCH...YMMV.
--
Daniel Rall <dl...@finemaltcoding.com>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] MIME types, peer review
Posted by Benjamin Pflugmann <be...@pflugmann.de>.
On Mon 2003-03-10 at 12:11:32 -0800, Daniel Rall wrote:
> Message-ID <3E...@therealm.demon.co.uk> contains a patch as
> an attachment.
Hummm. He explicitly explained why he did not mark with [PATCH]. If
you have reason to think marking it as patch nonetheless is the right
thing to do, you failed to explain those reasons.
Bye,
Benjamin.