You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/09/22 18:40:09 UTC

[GitHub] janpio edited a comment on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX

janpio edited a comment on issue #158: Splash screen images for iPhone XR, iPhone XS, and iPhone XSMAX
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/158#issuecomment-423764553
 
 
   Not really, congratulations on your first PR! 🥇 💯 
   
   (The tests are failing, but that is because they are failing for _all_ commits because of a infrastructure problem, the actual code tests seem to be fine)
   
   You can add `closes #158` in the description field, then it will automatically close this issue when it is merged.
   
   Now someone from the Apache Cordova team will have to look at, review and then merge it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org