You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/15 06:53:13 UTC
[GitHub] [flink] SteNicholas opened a new pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
SteNicholas opened a new pull request #14659:
URL: https://github.com/apache/flink/pull/14659
## What is the purpose of the change
*`ExecutionVertexVersioner` is used instead for concurrent global-local and local-local failures' handling. Therefore `ExecutionGraph#globalModVersion` should be removed because of this isn't used after legacy scheduler is removed. *
## Brief change log
- *Remove the `globalModVersion` variable in `ExecutionGraph`, which are used in `ExecutionJobVertex`, `ExecutionVertex` and `Execution` for concurrent global-local and local-local failures' handling.*
## Verifying this change
- *Update `CheckpointCoordinatorTestingUtils`, `ExecutionGraphPartitionReleaseTest`, `ExecutionVertexLocalityTest` and `ExecutionVertexTest` through removing the `globalModVersion`.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-764192618
@zhuzhurk , I have merged these commits into two commit and CI result is successful. Please check it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a change in pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #14659:
URL: https://github.com/apache/flink/pull/14659#discussion_r559941714
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -938,7 +929,7 @@ public void suspend(Throwable suspensionCause) {
initFailureCause(suspensionCause);
// make sure no concurrent local actions interfere with the cancellation
Review comment:
the comment is outdated
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
##########
@@ -855,7 +846,7 @@ public void cancel() {
if (transitionState(current, JobStatus.CANCELLING)) {
// make sure no concurrent local actions interfere with the cancellation
Review comment:
this comment is outdated.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertex.java
##########
@@ -499,13 +497,12 @@ public void fail(Throwable t) {
}
}
- public void resetForNewExecution(final long timestamp, final long expectedGlobalModVersion)
- throws GlobalModVersionMismatch {
+ public void resetForNewExecution(final long timestamp) {
Review comment:
it may be out of the scope of this task but I think this method is no longer needed in production code and can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk merged pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
zhuzhurk merged pull request #14659:
URL: https://github.com/apache/flink/pull/14659
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-760700709
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12098",
"triggerID" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"triggerType" : "PUSH"
}, {
"hash" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12244",
"triggerID" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"triggerType" : "PUSH"
}, {
"hash" : "f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12264",
"triggerID" : "f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e",
"triggerType" : "PUSH"
}, {
"hash" : "1f31cda86e725eceb1588856541c1ea3d56945c7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12272",
"triggerID" : "1f31cda86e725eceb1588856541c1ea3d56945c7",
"triggerType" : "PUSH"
}, {
"hash" : "cf3f4fd97e1252a06a982cdefafaf7cf9012f0b2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12288",
"triggerID" : "cf3f4fd97e1252a06a982cdefafaf7cf9012f0b2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1f31cda86e725eceb1588856541c1ea3d56945c7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12272)
* cf3f4fd97e1252a06a982cdefafaf7cf9012f0b2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12288)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-764192618
@zhuzhurk , I have merged these commits into two commit and CI result is successful. Please check it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk merged pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
zhuzhurk merged pull request #14659:
URL: https://github.com/apache/flink/pull/14659
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-763439100
@zhuzhurk , I have separated the commit for removing `resetForNewExecution` from `ExecutionJobVertex` and modified the previous commit that only remove the comments in `ExecutionGraph`. Please help to review again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-760700709
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12098",
"triggerID" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"triggerType" : "PUSH"
}, {
"hash" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12244",
"triggerID" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b050c2b3acb1c1309e9053364a6f22731dba21a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12098)
* 21f45aeedd834992a8cafa3e8d39ad230f943cf3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12244)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-760700709
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b050c2b3acb1c1309e9053364a6f22731dba21a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a change in pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #14659:
URL: https://github.com/apache/flink/pull/14659#discussion_r560832458
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java
##########
@@ -555,18 +555,7 @@ public void connectSource(
*
Review comment:
These comments are outdated except for the first sentence.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-762825923
@zhuzhurk , thanks for your detailed review. I have followed your comments and modified the comments and remove the `resetForNewExecution` in `ExecutionJobVertex`. Please help to review again if you are available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-760700709
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12098",
"triggerID" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"triggerType" : "PUSH"
}, {
"hash" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b050c2b3acb1c1309e9053364a6f22731dba21a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12098)
* 21f45aeedd834992a8cafa3e8d39ad230f943cf3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-760700709
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12098",
"triggerID" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"triggerType" : "PUSH"
}, {
"hash" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12244",
"triggerID" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"triggerType" : "PUSH"
}, {
"hash" : "f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12264",
"triggerID" : "f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e",
"triggerType" : "PUSH"
}, {
"hash" : "1f31cda86e725eceb1588856541c1ea3d56945c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12272",
"triggerID" : "1f31cda86e725eceb1588856541c1ea3d56945c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 21f45aeedd834992a8cafa3e8d39ad230f943cf3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12244)
* f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12264)
* 1f31cda86e725eceb1588856541c1ea3d56945c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12272)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-760700709
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12098",
"triggerID" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"triggerType" : "PUSH"
}, {
"hash" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12244",
"triggerID" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 21f45aeedd834992a8cafa3e8d39ad230f943cf3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12244)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-760693990
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1b050c2b3acb1c1309e9053364a6f22731dba21a (Fri Jan 15 06:55:08 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20931).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-760700709
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12098",
"triggerID" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"triggerType" : "PUSH"
}, {
"hash" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12244",
"triggerID" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"triggerType" : "PUSH"
}, {
"hash" : "f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12264",
"triggerID" : "f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 21f45aeedd834992a8cafa3e8d39ad230f943cf3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12244)
* f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12264)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-760700709
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12098",
"triggerID" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"triggerType" : "PUSH"
}, {
"hash" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12244",
"triggerID" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"triggerType" : "PUSH"
}, {
"hash" : "f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12264",
"triggerID" : "f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e",
"triggerType" : "PUSH"
}, {
"hash" : "1f31cda86e725eceb1588856541c1ea3d56945c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12272",
"triggerID" : "1f31cda86e725eceb1588856541c1ea3d56945c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12264)
* 1f31cda86e725eceb1588856541c1ea3d56945c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12272)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SteNicholas commented on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-762539098
@tillrohrmann @zhuzhurk , could you please help to review the simple pull request?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-760700709
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12098",
"triggerID" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"triggerType" : "PUSH"
}, {
"hash" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12244",
"triggerID" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"triggerType" : "PUSH"
}, {
"hash" : "f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 21f45aeedd834992a8cafa3e8d39ad230f943cf3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12244)
* f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-760700709
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12098",
"triggerID" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"triggerType" : "PUSH"
}, {
"hash" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12244",
"triggerID" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"triggerType" : "PUSH"
}, {
"hash" : "f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12264",
"triggerID" : "f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e",
"triggerType" : "PUSH"
}, {
"hash" : "1f31cda86e725eceb1588856541c1ea3d56945c7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1f31cda86e725eceb1588856541c1ea3d56945c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 21f45aeedd834992a8cafa3e8d39ad230f943cf3 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12244)
* f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12264)
* 1f31cda86e725eceb1588856541c1ea3d56945c7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-760700709
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12098",
"triggerID" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"triggerType" : "PUSH"
}, {
"hash" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12244",
"triggerID" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"triggerType" : "PUSH"
}, {
"hash" : "f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12264",
"triggerID" : "f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e",
"triggerType" : "PUSH"
}, {
"hash" : "1f31cda86e725eceb1588856541c1ea3d56945c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12272",
"triggerID" : "1f31cda86e725eceb1588856541c1ea3d56945c7",
"triggerType" : "PUSH"
}, {
"hash" : "cf3f4fd97e1252a06a982cdefafaf7cf9012f0b2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cf3f4fd97e1252a06a982cdefafaf7cf9012f0b2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12264)
* 1f31cda86e725eceb1588856541c1ea3d56945c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12272)
* cf3f4fd97e1252a06a982cdefafaf7cf9012f0b2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-760700709
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12098",
"triggerID" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b050c2b3acb1c1309e9053364a6f22731dba21a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12098)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a change in pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #14659:
URL: https://github.com/apache/flink/pull/14659#discussion_r560646431
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionJobVertex.java
##########
@@ -499,31 +497,6 @@ public void fail(Throwable t) {
}
}
- public void resetForNewExecution(final long timestamp, final long expectedGlobalModVersion)
Review comment:
I think `ExecutionVertex#resetForNewExecution(final long timestamp, final long originatingGlobalModVersion)` was used by this method. We should remove it as well.
Besides that, could we have a separate hotfix commit to remove this method because it is not the work of removing globalModVersion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-760700709
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12098",
"triggerID" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1b050c2b3acb1c1309e9053364a6f22731dba21a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12098)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14659: [FLINK-20931][coordination] Remove globalModVersion from ExecutionGraph
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14659:
URL: https://github.com/apache/flink/pull/14659#issuecomment-760700709
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12098",
"triggerID" : "1b050c2b3acb1c1309e9053364a6f22731dba21a",
"triggerType" : "PUSH"
}, {
"hash" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12244",
"triggerID" : "21f45aeedd834992a8cafa3e8d39ad230f943cf3",
"triggerType" : "PUSH"
}, {
"hash" : "f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12264",
"triggerID" : "f9e6021770ed79f0dd9aa7df316dc6a9b4f4ae0e",
"triggerType" : "PUSH"
}, {
"hash" : "1f31cda86e725eceb1588856541c1ea3d56945c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12272",
"triggerID" : "1f31cda86e725eceb1588856541c1ea3d56945c7",
"triggerType" : "PUSH"
}, {
"hash" : "cf3f4fd97e1252a06a982cdefafaf7cf9012f0b2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12288",
"triggerID" : "cf3f4fd97e1252a06a982cdefafaf7cf9012f0b2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cf3f4fd97e1252a06a982cdefafaf7cf9012f0b2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12288)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org