You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/04 02:18:18 UTC

[GitHub] [arrow] kou commented on a diff in pull request #13475: ARROW-16886: [C++] Add option to disable PIC

kou commented on code in PR #13475:
URL: https://github.com/apache/arrow/pull/13475#discussion_r912581031


##########
cpp/cmake_modules/DefineOptions.cmake:
##########
@@ -109,6 +109,9 @@ if(ARROW_DEFINE_OPTIONS)
 
   define_option(ARROW_NO_DEPRECATED_API "Exclude deprecated APIs from build" OFF)
 
+  define_option(ARROW_POSITION_INDEPENDENT_CODE

Review Comment:
   Good idea!
   But I disable `ARROW_POSITION_INDEPENDENT_CODE` (`ARROW_BUILD_SHARED=ON` and `ARROW_POSITION_INDEPENDENT_CODE=ON`) with `ARROW_BUILD_SHARED=ON` and `ARROW_POSITION_INDEPENDENT_CODE=OFF` instead of disabling `ARROW_BUILD_SHARED` (`ARROW_BUILD_SHARED=OFF` and `ARROW_POSITION_INDEPENDENT_CODE=OFF`). Because `ARROW_BUILD_SHARED=OFF` causes other errors with other options such as `ARROW_FLIGHT=ON`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org